Re: [PATCH 2/2] dh key: get rid of stack array allocation

2018-03-20 Thread Tycho Andersen
Hi Eric, On Wed, Mar 14, 2018 at 07:21:12PM -0700, Eric Biggers wrote: > On Mon, Mar 12, 2018 at 10:29:07PM -0600, Tycho Andersen wrote: > > Similarly to the previous patch, we would like to get rid of stack > > allocated arrays: https://lkml.org/lkml/2018/3/7/621 > > > > In this case, we can als

Re: [PATCH 2/2] dh key: get rid of stack array allocation

2018-03-14 Thread Eric Biggers
On Mon, Mar 12, 2018 at 10:29:07PM -0600, Tycho Andersen wrote: > Similarly to the previous patch, we would like to get rid of stack > allocated arrays: https://lkml.org/lkml/2018/3/7/621 > > In this case, we can also use a malloc style approach to free the temporary > buffer, being careful to als

Re: [PATCH 2/2] dh key: get rid of stack array allocation

2018-03-13 Thread Serge E. Hallyn
Quoting Tycho Andersen (ty...@tycho.ws): > Similarly to the previous patch, we would like to get rid of stack > allocated arrays: https://lkml.org/lkml/2018/3/7/621 > > In this case, we can also use a malloc style approach to free the temporary > buffer, being careful to also use kzfree to free th

[PATCH 2/2] dh key: get rid of stack array allocation

2018-03-12 Thread Tycho Andersen
Similarly to the previous patch, we would like to get rid of stack allocated arrays: https://lkml.org/lkml/2018/3/7/621 In this case, we can also use a malloc style approach to free the temporary buffer, being careful to also use kzfree to free them (indeed, at least one of these has a memzero_exp