Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-13 Thread Ross Zwisler
On Tue, Oct 13, 2015 at 12:35:44AM +0100, Eric Curtin wrote: > Hi Ross, > > For all those int ret declarations. Why not declare and initialize all > on the same line? > > Regards, > Eric Because the return value 'ret' is set unconditionally later in the function as part of a call into the DAX co

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-13 Thread Jan Kara
On Tue 13-10-15 11:33:20, Ross Zwisler wrote: > On Tue, Oct 13, 2015 at 10:07:12AM +0200, Jan Kara wrote: > > On Mon 12-10-15 15:41:35, Ross Zwisler wrote: > > > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > >

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-13 Thread Ross Zwisler
On Tue, Oct 13, 2015 at 10:07:12AM +0200, Jan Kara wrote: > On Mon 12-10-15 15:41:35, Ross Zwisler wrote: > > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > > > Add locking to ensure that DAX faults are isolated

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-13 Thread Ross Zwisler
On Tue, Oct 13, 2015 at 10:24:28AM +1100, Dave Chinner wrote: > On Mon, Oct 12, 2015 at 03:41:35PM -0600, Ross Zwisler wrote: > > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > > > Add locking to ensure that DAX

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-13 Thread Jan Kara
On Mon 12-10-15 15:41:35, Ross Zwisler wrote: > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > > Add locking to ensure that DAX faults are isolated from ext2 operations > > > that modify the data blocks allocation

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-12 Thread Eric Curtin
On 13 October 2015 at 00:24, Dave Chinner wrote: > > On Mon, Oct 12, 2015 at 03:41:35PM -0600, Ross Zwisler wrote: > > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > > > Add locking to ensure that DAX faults are

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-12 Thread Dave Chinner
On Mon, Oct 12, 2015 at 03:41:35PM -0600, Ross Zwisler wrote: > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > > Add locking to ensure that DAX faults are isolated from ext2 operations > > > that modify the data bl

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-12 Thread Dave Chinner
On Mon, Oct 12, 2015 at 11:21:56AM -0600, Ross Zwisler wrote: > On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > <> > > > +/* > > > + * The lock ordering for ext2 DAX fault paths is: > > > + * > > > + * mmap_sem (MM) >

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-12 Thread Ross Zwisler
On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > On Fri, Oct 09, 2015 at 04:02:08PM -0600, Ross Zwisler wrote: > > Add locking to ensure that DAX faults are isolated from ext2 operations > > that modify the data blocks allocation for an inode. This is intended to > > be analogous to

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-12 Thread Ross Zwisler
On Mon, Oct 12, 2015 at 10:14:43AM +1100, Dave Chinner wrote: > [Nit: please send all patches of the series to the same list of > recipients. Otherwise people with list based filters end up with the > series spread across different mailboxes and people not subscribed > to all lists don't get the fu

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-11 Thread Dave Chinner
[Nit: please send all patches of the series to the same list of recipients. Otherwise people with list based filters end up with the series spread across different mailboxes and people not subscribed to all lists don't get the full series and so are lacking in context for proper review. ] On Fri,

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-09 Thread Ross Zwisler
On Fri, Oct 09, 2015 at 03:18:11PM -0700, Dan Williams wrote: > On Fri, Oct 9, 2015 at 3:02 PM, Ross Zwisler > wrote: > > Add locking to ensure that DAX faults are isolated from ext2 operations > > that modify the data blocks allocation for an inode. This is intended to > > be analogous to the wo

Re: [PATCH 2/2] ext2: Add locking for DAX faults

2015-10-09 Thread Dan Williams
On Fri, Oct 9, 2015 at 3:02 PM, Ross Zwisler wrote: > Add locking to ensure that DAX faults are isolated from ext2 operations > that modify the data blocks allocation for an inode. This is intended to > be analogous to the work being done in XFS by Dave Chinner: > > http://www.spinics.net/lists/l

[PATCH 2/2] ext2: Add locking for DAX faults

2015-10-09 Thread Ross Zwisler
Add locking to ensure that DAX faults are isolated from ext2 operations that modify the data blocks allocation for an inode. This is intended to be analogous to the work being done in XFS by Dave Chinner: http://www.spinics.net/lists/linux-fsdevel/msg90260.html Compared with XFS the ext2 case is