Re: [f2fs-dev] [PATCH 2/2] f2fs: don't overwrite node block by SSR

2017-03-09 Thread Chao Yu
On 2017/3/9 5:39, Jaegeuk Kim wrote: > On 03/08, Chao Yu wrote: >> On 2017/3/7 5:51, Jaegeuk Kim wrote: >>> This patch fixes that SSR can overwrite previous warm node block consisting >>> of >>> a node chain since the last checkpoint. >> >> Good catch! >> >> Need to consider the impact to other ac

Re: [f2fs-dev] [PATCH 2/2] f2fs: don't overwrite node block by SSR

2017-03-08 Thread Jaegeuk Kim
On 03/08, Chao Yu wrote: > On 2017/3/7 5:51, Jaegeuk Kim wrote: > > This patch fixes that SSR can overwrite previous warm node block consisting > > of > > a node chain since the last checkpoint. > > Good catch! > > Need to consider the impact to other accesser, e.g. is_checkpointed_data, > add_d

Re: [f2fs-dev] [PATCH 2/2] f2fs: don't overwrite node block by SSR

2017-03-08 Thread Chao Yu
On 2017/3/7 5:51, Jaegeuk Kim wrote: > This patch fixes that SSR can overwrite previous warm node block consisting of > a node chain since the last checkpoint. Good catch! Need to consider the impact to other accesser, e.g. is_checkpointed_data, add_discard_addrs? Thanks, > > Fixes: 5b6c6be2d8

[PATCH 2/2] f2fs: don't overwrite node block by SSR

2017-03-06 Thread Jaegeuk Kim
This patch fixes that SSR can overwrite previous warm node block consisting of a node chain since the last checkpoint. Fixes: 5b6c6be2d878 ("f2fs: use SSR for warm node as well") Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/f2fs/se