[PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Chao Yu
In following call stack, if unfortunately we lose all chances to truncate inode page in remove_inode_page, eventually we will add the nid allocated previously into free nid cache, this nid is with NID_NEW status and with NEW_ADDR in its blkaddr pointer: - f2fs_create - f2fs_add_link - __f2fs

Re: [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Jaegeuk Kim
On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrote: > In following call stack, if unfortunately we lose all chances to truncate > inode page in remove_inode_page, eventually we will add the nid allocated > previously into free nid cache, this nid is with NID_NEW status and with > NEW_ADDR in i

RE: [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, August 25, 2015 12:54 AM > To: Chao Yu > Cc: linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/2] f2fs: fix to release inode c

Re: [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-25 Thread Jaegeuk Kim
ge.net; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH 2/2] f2fs: fix to release inode correctly > > > > [snip] > > > > + * if we skip truncate_node in remove_inode_page bacause we failed > > > + * before, it's better to find another way to release res

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Jaegeuk Kim
Hi Chao, On Mon, Aug 24, 2015 at 09:54:23AM -0700, Jaegeuk Kim wrote: > On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrote: > > In following call stack, if unfortunately we lose all chances to truncate > > inode page in remove_inode_page, eventually we will add the nid allocated > > previousl

RE: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, August 25, 2015 6:53 AM > To: Chao Yu > Cc: linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to relea

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-25 Thread Jaegeuk Kim
nux-f2fs-de...@lists.sourceforge.net > > Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly > > > > Hi Chao, > > > > On Mon, Aug 24, 2015 at 09:54:23AM -0700, Jaegeuk Kim wrote: > > > On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrot

RE: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-26 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, August 26, 2015 6:40 AM > To: Chao Yu > Cc: linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode cor