Re: [PATCH 2/2] f2fs: introduce CP_TRIMMED_FLAG to avoid unneeded discard

2017-04-27 Thread Chao Yu
Hi Jaegeuk, On 2017/4/28 2:16, Jaegeuk Kim wrote: > Hi Chao, > > Could you add this state in print_cp_state() of f2fs-tools as well? Oh, right, and we can set the flag after trimming in mkfs, also we need to adjust this state into trace info. Let me fix this. :) Thanks, > > Thanks, > > On 0

Re: [PATCH 2/2] f2fs: introduce CP_TRIMMED_FLAG to avoid unneeded discard

2017-04-27 Thread Jaegeuk Kim
Hi Chao, Could you add this state in print_cp_state() of f2fs-tools as well? Thanks, On 04/27, Chao Yu wrote: > Introduce CP_TRIMMED_FLAG to indicate all invalid block were trimmed > before umount, so once we do mount with image which contain the flag, > we don't record invalid blocks as undisca

[PATCH 2/2] f2fs: introduce CP_TRIMMED_FLAG to avoid unneeded discard

2017-04-27 Thread Chao Yu
Introduce CP_TRIMMED_FLAG to indicate all invalid block were trimmed before umount, so once we do mount with image which contain the flag, we don't record invalid blocks as undiscard one, when fstrim is being triggered, we can avoid issuing redundant discard commands. Signed-off-by: Chao Yu ---