Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-04-17 Thread Chao Yu
On 2018/4/17 11:38, Jaegeuk Kim wrote: > On 04/13, Chao Yu wrote: >> Ping again.. >> >> Do you have time to discuss this? > > We may need a time to have a chat in person. Do you have any chance to visit > US? I prefer to, just count on LSF, but... I think I need to find a conference which is ope

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-04-16 Thread Jaegeuk Kim
On 04/13, Chao Yu wrote: > Ping again.. > > Do you have time to discuss this? We may need a time to have a chat in person. Do you have any chance to visit US? > > On 2018/2/27 22:16, Chao Yu wrote: > > Ping, > > > > On 2018/2/13 15:34, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2018/2/10 10:

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-04-13 Thread Chao Yu
Ping again.. Do you have time to discuss this? On 2018/2/27 22:16, Chao Yu wrote: > Ping, > > On 2018/2/13 15:34, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2018/2/10 10:52, Chao Yu wrote: >>> On 2018/2/10 9:41, Jaegeuk Kim wrote: On 02/01, Chao Yu wrote: > > > On 2018/2/1 6:15, Jae

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-02-28 Thread Chao Yu
On 2018/2/28 13:34, Jaegeuk Kim wrote: > On 02/27, Chao Yu wrote: >> Ping, >> >> On 2018/2/13 15:34, Chao Yu wrote: >>> Hi Jaegeuk, >>> >>> On 2018/2/10 10:52, Chao Yu wrote: On 2018/2/10 9:41, Jaegeuk Kim wrote: > On 02/01, Chao Yu wrote: >> >> >> On 2018/2/1 6:15, Jaegeuk Kim

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-02-27 Thread Jaegeuk Kim
On 02/27, Chao Yu wrote: > Ping, > > On 2018/2/13 15:34, Chao Yu wrote: > > Hi Jaegeuk, > > > > On 2018/2/10 10:52, Chao Yu wrote: > >> On 2018/2/10 9:41, Jaegeuk Kim wrote: > >>> On 02/01, Chao Yu wrote: > > > On 2018/2/1 6:15, Jaegeuk Kim wrote: > > On 01/31, Chao Yu wrote: >

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-02-27 Thread Chao Yu
Ping, On 2018/2/13 15:34, Chao Yu wrote: > Hi Jaegeuk, > > On 2018/2/10 10:52, Chao Yu wrote: >> On 2018/2/10 9:41, Jaegeuk Kim wrote: >>> On 02/01, Chao Yu wrote: On 2018/2/1 6:15, Jaegeuk Kim wrote: > On 01/31, Chao Yu wrote: >> On 2018/1/31 10:02, Jaegeuk Kim wrote:

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-02-12 Thread Chao Yu
Hi Jaegeuk, On 2018/2/10 10:52, Chao Yu wrote: > On 2018/2/10 9:41, Jaegeuk Kim wrote: >> On 02/01, Chao Yu wrote: >>> >>> >>> On 2018/2/1 6:15, Jaegeuk Kim wrote: On 01/31, Chao Yu wrote: > On 2018/1/31 10:02, Jaegeuk Kim wrote: >> What if we want to add more entries in addition to n

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-02-09 Thread Chao Yu
On 2018/2/10 9:41, Jaegeuk Kim wrote: > On 02/01, Chao Yu wrote: >> >> >> On 2018/2/1 6:15, Jaegeuk Kim wrote: >>> On 01/31, Chao Yu wrote: On 2018/1/31 10:02, Jaegeuk Kim wrote: > What if we want to add more entries in addition to node_checksum? Do we > have > to add a new featur

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-02-09 Thread Jaegeuk Kim
On 02/01, Chao Yu wrote: > > > On 2018/2/1 6:15, Jaegeuk Kim wrote: > > On 01/31, Chao Yu wrote: > >> On 2018/1/31 10:02, Jaegeuk Kim wrote: > >>> What if we want to add more entries in addition to node_checksum? Do we > >>> have > >>> to add a new feature flag at every time? How about adding a

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-02-01 Thread Chao Yu
On 2018/2/1 6:15, Jaegeuk Kim wrote: > On 01/31, Chao Yu wrote: >> On 2018/1/31 10:02, Jaegeuk Kim wrote: >>> What if we want to add more entries in addition to node_checksum? Do we have >>> to add a new feature flag at every time? How about adding a layout value >>> instead >> >> Hmm.. for prev

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-01-31 Thread Jaegeuk Kim
On 01/31, Chao Yu wrote: > On 2018/1/31 10:02, Jaegeuk Kim wrote: > > What if we want to add more entries in addition to node_checksum? Do we have > > to add a new feature flag at every time? How about adding a layout value > > instead > > Hmm.. for previous implementation, IMO, we'd better add a

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-01-30 Thread Chao Yu
On 2018/1/31 10:02, Jaegeuk Kim wrote: > What if we want to add more entries in addition to node_checksum? Do we have > to add a new feature flag at every time? How about adding a layout value > instead Hmm.. for previous implementation, IMO, we'd better add a new feature flag at every time, othe

Re: [PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-01-30 Thread Jaegeuk Kim
On 01/27, Chao Yu wrote: > This patch adds to support {d,id,did,x}node checksum in kernel side. > > Signed-off-by: Chao Yu > --- > fs/f2fs/f2fs.h | 15 +++- > fs/f2fs/inode.c | 98 > +++-- > fs/f2fs/node.c | 2 +- > fs/f

[PATCH 2/2] f2fs: support {d,id,did,x}node checksum

2018-01-27 Thread Chao Yu
This patch adds to support {d,id,did,x}node checksum in kernel side. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 15 +++- fs/f2fs/inode.c | 98 +++-- fs/f2fs/node.c | 2 +- fs/f2fs/segment.c | 2 +- fs/f2fs/sysfs.c