There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case add a ‘-’ so as to match the regular expression expected by GCC. This commit remove the following warning: /drivers/firewire/core-device.c: In function 'set_broadcast_channel': ../drivers/firewire/core-device.c:969:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (data & cpu_to_be32(1 << 31)) { Signed-off-by: Mathieu Malaterre <ma...@debian.org> --- drivers/firewire/core-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index 7c2eed76011e..e41d55b04940 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -970,7 +970,7 @@ static void set_broadcast_channel(struct fw_device *device, int generation) device->bc_implemented = BC_IMPLEMENTED; break; } - /* else fall through to case address error */ + /* else fall through - to case address error */ case RCODE_ADDRESS_ERROR: device->bc_implemented = BC_UNIMPLEMENTED; } -- 2.19.2