Re: [PATCH 2/2] fix up new filp allocators

2007-11-09 Thread J. Bruce Fields
On Fri, Nov 09, 2007 at 01:35:22PM -0800, Dave Hansen wrote: > On Fri, 2007-11-09 at 16:26 -0500, Trond Myklebust wrote: > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -1303,7 +1304,7 @@ static inline void > > >

Re: [PATCH 2/2] fix up new filp allocators

2007-11-09 Thread Dave Hansen
On Fri, 2007-11-09 at 16:26 -0500, Trond Myklebust wrote: > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -1303,7 +1304,7 @@ static inline void > > nfs4_file_downgrade(struct file *filp, unsigned int share_access) > > { > > if

Re: [PATCH 2/2] fix up new filp allocators

2007-11-09 Thread Trond Myklebust
On Fri, 2007-11-09 at 13:04 -0800, Dave Hansen wrote: > Some new uses of get_empty_filp() have crept in, and are > not properly taking mnt_want_write()s. This fixes them > up. > > We really need to kill get_empty_filp(). > > Signed-off-by: Dave Hansen <[EMAIL PROTECTED]> > --- > >

[PATCH 2/2] fix up new filp allocators

2007-11-09 Thread Dave Hansen
Some new uses of get_empty_filp() have crept in, and are not properly taking mnt_want_write()s. This fixes them up. We really need to kill get_empty_filp(). Signed-off-by: Dave Hansen <[EMAIL PROTECTED]> --- linux-2.6.git-dave/fs/anon_inodes.c| 16 ++--

[PATCH 2/2] fix up new filp allocators

2007-11-09 Thread Dave Hansen
Some new uses of get_empty_filp() have crept in, and are not properly taking mnt_want_write()s. This fixes them up. We really need to kill get_empty_filp(). Signed-off-by: Dave Hansen [EMAIL PROTECTED] --- linux-2.6.git-dave/fs/anon_inodes.c| 16 ++--

Re: [PATCH 2/2] fix up new filp allocators

2007-11-09 Thread Trond Myklebust
On Fri, 2007-11-09 at 13:04 -0800, Dave Hansen wrote: Some new uses of get_empty_filp() have crept in, and are not properly taking mnt_want_write()s. This fixes them up. We really need to kill get_empty_filp(). Signed-off-by: Dave Hansen [EMAIL PROTECTED] ---

Re: [PATCH 2/2] fix up new filp allocators

2007-11-09 Thread Dave Hansen
On Fri, 2007-11-09 at 16:26 -0500, Trond Myklebust wrote: #include linux/sunrpc/svc.h #include linux/nfsd/nfsd.h #include linux/nfsd/cache.h +#include linux/file.h #include linux/mount.h #include linux/workqueue.h #include linux/smp_lock.h @@ -1303,7 +1304,7 @@ static inline

Re: [PATCH 2/2] fix up new filp allocators

2007-11-09 Thread J. Bruce Fields
On Fri, Nov 09, 2007 at 01:35:22PM -0800, Dave Hansen wrote: On Fri, 2007-11-09 at 16:26 -0500, Trond Myklebust wrote: #include linux/sunrpc/svc.h #include linux/nfsd/nfsd.h #include linux/nfsd/cache.h +#include linux/file.h #include linux/mount.h #include linux/workqueue.h