Re: [PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-09 Thread Herton Ronaldo Krzesinski
On Wed, Aug 08, 2012 at 03:57:30PM -0400, Vivek Goyal wrote: > On Wed, Aug 08, 2012 at 03:24:53PM -0300, Herton Ronaldo Krzesinski wrote: > > While looking at commit 3f9a5aa ("floppy: Cleanup disk->queue before > > caling put_disk() if add_disk() was never called") I noticed some > > problems with

Re: [PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-09 Thread Herton Ronaldo Krzesinski
On Wed, Aug 08, 2012 at 03:57:30PM -0400, Vivek Goyal wrote: On Wed, Aug 08, 2012 at 03:24:53PM -0300, Herton Ronaldo Krzesinski wrote: While looking at commit 3f9a5aa (floppy: Cleanup disk-queue before caling put_disk() if add_disk() was never called) I noticed some problems with the error

Re: [PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-08 Thread Vivek Goyal
On Wed, Aug 08, 2012 at 03:24:53PM -0300, Herton Ronaldo Krzesinski wrote: > While looking at commit 3f9a5aa ("floppy: Cleanup disk->queue before > caling put_disk() if add_disk() was never called") I noticed some > problems with the error handling and cleanup: > > * missing cleanup (put_disk) if

[PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-08 Thread Herton Ronaldo Krzesinski
While looking at commit 3f9a5aa ("floppy: Cleanup disk->queue before caling put_disk() if add_disk() was never called") I noticed some problems with the error handling and cleanup: * missing cleanup (put_disk) if blk_init_queue fails, dr is decremented first in the error handling loop * if

[PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-08 Thread Herton Ronaldo Krzesinski
While looking at commit 3f9a5aa (floppy: Cleanup disk-queue before caling put_disk() if add_disk() was never called) I noticed some problems with the error handling and cleanup: * missing cleanup (put_disk) if blk_init_queue fails, dr is decremented first in the error handling loop * if

Re: [PATCH 2/2] floppy: error handling fixes on do_floppy_init

2012-08-08 Thread Vivek Goyal
On Wed, Aug 08, 2012 at 03:24:53PM -0300, Herton Ronaldo Krzesinski wrote: While looking at commit 3f9a5aa (floppy: Cleanup disk-queue before caling put_disk() if add_disk() was never called) I noticed some problems with the error handling and cleanup: * missing cleanup (put_disk) if