Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Eric Paris
On Tue, 2014-10-21 at 10:18 -0700, j...@joshtriplett.org wrote: > On Tue, Oct 21, 2014 at 08:37:00AM -0700, H. Peter Anvin wrote: > > On 10/20/2014 02:48 PM, Pieter Smith wrote: > > > Many embedded systems will not need this syscall, and omitting it > > > saves space. Add a new EXPERT config optio

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
On Tue, Oct 21, 2014 at 02:13:56AM -0700, Christoph Hellwig wrote: > On Tue, Oct 21, 2014 at 02:04:22AM -0700, Josh Triplett wrote: > > That's the plan, but since sendfile depends on some of the splice bits, > > sendfile needs to be optional as well; SENDFILE_SYSCALL will then select > > SPLICE_SYS

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Christoph Hellwig
On Tue, Oct 21, 2014 at 02:04:22AM -0700, Josh Triplett wrote: > That's the plan, but since sendfile depends on some of the splice bits, > sendfile needs to be optional as well; SENDFILE_SYSCALL will then select > SPLICE_SYSCALLS. Just include sendfile with the splice syscalls - we don't really ne

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
On Tue, Oct 21, 2014 at 12:51:54AM -0700, Christoph Hellwig wrote: > On Mon, Oct 20, 2014 at 03:24:22PM -0700, j...@joshtriplett.org wrote: > > On Mon, Oct 20, 2014 at 11:48:37PM +0200, Pieter Smith wrote: > > > Many embedded systems will not need this syscall, and omitting it > > > saves space. A

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 03:24:22PM -0700, j...@joshtriplett.org wrote: > On Mon, Oct 20, 2014 at 11:48:37PM +0200, Pieter Smith wrote: > > Many embedded systems will not need this syscall, and omitting it > > saves space. Add a new EXPERT config option CONFIG_SENDFILE_SYSCALL > > (default y) to su

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-20 Thread josh
On Mon, Oct 20, 2014 at 11:48:37PM +0200, Pieter Smith wrote: > Many embedded systems will not need this syscall, and omitting it > saves space. Add a new EXPERT config option CONFIG_SENDFILE_SYSCALL > (default y) to support compiling it out. Nice work, thanks! If there are no objections, and no

[PATCH 2/2] fs: Support compiling out sendfile

2014-10-20 Thread Pieter Smith
Many embedded systems will not need this syscall, and omitting it saves space. Add a new EXPERT config option CONFIG_SENDFILE_SYSCALL (default y) to support compiling it out. bloat-o-meter: add/remove: 0/4 grow/shrink: 5/0 up/down: 23/-751 (-728) function old