Re: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2020-10-20 Thread Jens Axboe
On Sat, Oct 17, 2020 at 2:11 PM Kent Overstreet wrote: > > Convert generic_file_buffered_read() to get pages to read from in > batches, and then copy data to userspace from many pages at once - in > particular, we now don't touch any cachelines that might be contended > while we're in the loop

[PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2020-10-17 Thread Kent Overstreet
Convert generic_file_buffered_read() to get pages to read from in batches, and then copy data to userspace from many pages at once - in particular, we now don't touch any cachelines that might be contended while we're in the loop to copy data to userspace. This is is a performance improvement on

Re: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2020-06-09 Thread Kent Overstreet
On Tue, Jun 09, 2020 at 06:38:08PM -0700, Matthew Wilcox wrote: > On Tue, Jun 09, 2020 at 08:10:36PM -0400, Kent Overstreet wrote: > > Convert generic_file_buffered_read() to get pages to read from in > > batches, and then copy data to userspace from many pages at once - in > > particular, we now

Re: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2020-06-09 Thread Matthew Wilcox
On Tue, Jun 09, 2020 at 08:10:36PM -0400, Kent Overstreet wrote: > Convert generic_file_buffered_read() to get pages to read from in > batches, and then copy data to userspace from many pages at once - in > particular, we now don't touch any cachelines that might be contended > while we're in the

Re: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2020-06-09 Thread Kent Overstreet
On Tue, Jun 09, 2020 at 05:47:53PM -0700, Matthew Wilcox wrote: > On Tue, Jun 09, 2020 at 08:10:36PM -0400, Kent Overstreet wrote: > > @@ -2275,83 +2287,93 @@ static ssize_t generic_file_buffered_read(struct > > kiocb *iocb, > > struct iov_iter *iter, ssize_t written) > > { > >

Re: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2020-06-09 Thread Matthew Wilcox
On Tue, Jun 09, 2020 at 08:10:36PM -0400, Kent Overstreet wrote: > @@ -2275,83 +2287,93 @@ static ssize_t generic_file_buffered_read(struct > kiocb *iocb, > struct iov_iter *iter, ssize_t written) > { > struct file *filp = iocb->ki_filp; > + struct file_ra_state *ra =

[PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2020-06-09 Thread Kent Overstreet
Convert generic_file_buffered_read() to get pages to read from in batches, and then copy data to userspace from many pages at once - in particular, we now don't touch any cachelines that might be contended while we're in the loop to copy data to userspace. This is is a performance improvement on

Re: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2018-08-16 Thread kbuild test robot
Hi Kent, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18 next-20180816] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2018-08-16 Thread kbuild test robot
Hi Kent, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18 next-20180816] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2018-08-15 Thread Kent Overstreet
Convert generic_file_buffered_read() to get pages to read from in batches, and then copy data to userspace from many pages at once - in particular, we now don't touch any cachelines that might be contended while we're in the loop to copy data to userspace. This is is a performance improvement on

[PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig

2018-08-15 Thread Kent Overstreet
Convert generic_file_buffered_read() to get pages to read from in batches, and then copy data to userspace from many pages at once - in particular, we now don't touch any cachelines that might be contended while we're in the loop to copy data to userspace. This is is a performance improvement on