Re: [PATCH 2/2] ftrace/x86/extable: Add is_ftrace_trampoline() function

2014-11-19 Thread Steven Rostedt
On Wed, 19 Nov 2014 19:29:25 +0100 (CET) Thomas Gleixner wrote: > On Wed, 19 Nov 2014, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > Date: Tue, 18 Nov 2014 21:14:11 -0500 > > Subject: [PATCH] ftrace/x86/extable: Add is_ftrace_trampoline() function > > > > Stack traces that happ

Re: [PATCH 2/2] ftrace/x86/extable: Add is_ftrace_trampoline() function

2014-11-19 Thread Thomas Gleixner
On Wed, 19 Nov 2014, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > Date: Tue, 18 Nov 2014 21:14:11 -0500 > Subject: [PATCH] ftrace/x86/extable: Add is_ftrace_trampoline() function > > Stack traces that happen from function tracing check if the address > on the stack is a __kernel_tex

Re: [PATCH 2/2] ftrace/x86/extable: Add is_ftrace_trampoline() function

2014-11-19 Thread Steven Rostedt
On Wed, 19 Nov 2014 17:16:55 +0900 Namhyung Kim wrote: > > [SNIP] > > @@ -102,6 +103,8 @@ int __kernel_text_address(unsigned long addr) > > return 1; > > if (is_module_text_address(addr)) > > return 1; > > + if (is_ftrace_trampoline(addr)) > > + return 1;

Re: [PATCH 2/2] ftrace/x86/extable: Add is_ftrace_trampoline() function

2014-11-19 Thread Steven Rostedt
> > [SNIP] > > @@ -102,6 +103,8 @@ int __kernel_text_address(unsigned long addr) > > return 1; > > if (is_module_text_address(addr)) > > return 1; > > + if (is_ftrace_trampoline(addr)) > > + return 1; > > What about kernel_text_address()? It seems some ar

Re: [PATCH 2/2] ftrace/x86/extable: Add is_ftrace_trampoline() function

2014-11-19 Thread Namhyung Kim
Hi Steve, On Tue, 18 Nov 2014 22:33:33 -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Stack traces that happen from function tracing check if the address > on the stack is a __kernel_text_address(). That is, is the address > kernel code. This calls core_kernel_text() which re

Re: [PATCH 2/2] ftrace/x86/extable: Add is_ftrace_trampoline() function

2014-11-18 Thread Steven Rostedt
On Tue, 18 Nov 2014 22:33:33 -0500 Steven Rostedt wrote: > +/* > + * This is used by __kernel_text_address() to return true if the > + * the address is on a dynamically allocated trampoline that would > + * not return true for either core_kernel_text() or > + * is_module_text_address(). > + */ >

[PATCH 2/2] ftrace/x86/extable: Add is_ftrace_trampoline() function

2014-11-18 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Stack traces that happen from function tracing check if the address on the stack is a __kernel_text_address(). That is, is the address kernel code. This calls core_kernel_text() which returns true if the address is part of the builtin kernel code. It also calls is