Re: [PATCH 2/2] gpio: mcp23s08: add pinconf support

2017-02-01 Thread Linus Walleij
On Mon, Jan 30, 2017 at 5:40 PM, Sebastian Reichel wrote: >> Can we move the patch to drivers/pinctrl/* like all other mixed drivers >> doing combined pinctrl and GPIO? > > Sure. Two questions: > > * Should the config name change to PINCTRL_MCP23s08 (or PINCTRL_MCP23XXX)? >This will mean peo

Re: [PATCH 2/2] gpio: mcp23s08: add pinconf support

2017-01-30 Thread Sebastian Reichel
Hi Linus, On Mon, Jan 30, 2017 at 04:08:01PM +0100, Linus Walleij wrote: > On Fri, Jan 27, 2017 at 3:47 PM, Sebastian Reichel wrote: > > > mcp23xxx device have configurable 100k pullup resistors. This adds > > support for enabling them using pinctrl's pinconf interface. > > > > Signed-off-by: Se

Re: [PATCH 2/2] gpio: mcp23s08: add pinconf support

2017-01-30 Thread Linus Walleij
On Fri, Jan 27, 2017 at 3:47 PM, Sebastian Reichel wrote: > mcp23xxx device have configurable 100k pullup resistors. This adds > support for enabling them using pinctrl's pinconf interface. > > Signed-off-by: Sebastian Reichel That's the right approach! > diff --git a/drivers/gpio/gpio-mcp23s0

Re: [PATCH 2/2] gpio: mcp23s08: add pinconf support

2017-01-27 Thread kbuild test robot
Hi Sebastian, [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.10-rc5 next-20170125] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sebastian-Reichel/mcp23s08-pinconf-suppor

Re: [PATCH 2/2] gpio: mcp23s08: add pinconf support

2017-01-27 Thread kbuild test robot
Hi Sebastian, [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.10-rc5 next-20170125] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sebastian-Reichel/mcp23s08-pinconf-suppor

[PATCH 2/2] gpio: mcp23s08: add pinconf support

2017-01-27 Thread Sebastian Reichel
mcp23xxx device have configurable 100k pullup resistors. This adds support for enabling them using pinctrl's pinconf interface. Signed-off-by: Sebastian Reichel --- drivers/gpio/gpio-mcp23s08.c | 200 +-- 1 file changed, 176 insertions(+), 24 deletions(-)