On Tuesday 27 November 2007, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday 27 November 2007, Andrew Morton wrote:
> > On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng <[EMAIL PROTECTED]> wrote:
> >
> > > these utilities implemented in lib/hexdump.c are more handy, please use
> > > this.
> > >
> >
On Tuesday 27 November 2007, Andrew Morton wrote:
> On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng <[EMAIL PROTECTED]> wrote:
>
> > these utilities implemented in lib/hexdump.c are more handy, please use
> > this.
> >
> > ...
> >
> > --- a/drivers/scsi/ide-scsi.c
> > +++ b/drivers/scsi/ide-scsi.
On Tue, 2007-11-27 at 01:31 -0800, Andrew Morton wrote:
> Either way, perhaps a simple little front-end to print_hex_dump() is called
> for.
Perhaps an even simpler generic version of what's
now used in crypto/tcrypt.c:
void print_cont_hex_dump_bytes(const void *buf, size_t len)
{
print_h
On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng <[EMAIL PROTECTED]> wrote:
> these utilities implemented in lib/hexdump.c are more handy, please use this.
>
> ...
>
> --- a/drivers/scsi/ide-scsi.c
> +++ b/drivers/scsi/ide-scsi.c
> @@ -242,16 +242,6 @@ static void idescsi_output_buffers (ide_drive_
Matthew Wilcox wrote:
On Mon, Nov 26, 2007 at 04:37:50PM +0800, rae l wrote:
I know this is different from the original hexdump in ide-scsi.c, I
just want to tell someone that there's a good implementation of
hexdump in kernel.h, and I think the default KERN_DEBUG and
print_hex_dump is more info
On Mon, Nov 26, 2007 at 04:37:50PM +0800, rae l wrote:
> I know this is different from the original hexdump in ide-scsi.c, I
> just want to tell someone that there's a good implementation of
> hexdump in kernel.h, and I think the default KERN_DEBUG and
> print_hex_dump is more informative and has b
On Nov 26, 2007 3:41 PM, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-11-26 at 15:16 +0800, Denis Cheng wrote:
> > diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
> > index 8d0244c..8f3fc1d 100644
> > --- a/drivers/scsi/ide-scsi.c
> > +++ b/drivers/scsi/ide-scsi.c
> > @@ -28
these utilities implemented in lib/hexdump.c are more handy, please use this.
Cc: Randy Dunlap <[EMAIL PROTECTED]>
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
there are still much other private hexdump implementations in the source,
which reinvent the wheel, we can find them through:
$ g
8 matches
Mail list logo
