gt;> To: Tirdea, Irina
> >> Cc: Jonathan Cameron; linux-...@vger.kernel.org;
> >> linux-kernel@vger.kernel.org; Pandruvada, Srinivas; Reus, Adriana
> >> Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in
> >> trigger handler
> >
@vger.kernel.org; Pandruvada, Srinivas; Reus, Adriana
Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in
trigger handler
Reading all axis values in one i2c transfer reduces the delays
introduced by the i2c bus. In case i2c block read is not supported,
fallback to reading
ger.kernel.org; Pandruvada, Srinivas; Reus, Adriana
>> Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in
>> trigger handler
>>
>>
>>> Reading all axis values in one i2c transfer reduces the delays
>>> introduced by the i2c bus. In case i
: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in
trigger handler
Reading all axis values in one i2c transfer reduces the delays
introduced by the i2c bus. In case i2c block read is not supported,
fallback to reading each axis as a separate word.
see comments inline below
On Fri, 2015-02-20 at 16:23 +0100, Peter Meerwald wrote:
> > > > > +
> > > > > + values[i] = data & 0xFF;
> > > > > + values[i+1] = data >> 8;
> > > >
> > > > this is incorrect; it forces the data to be little endian, however, the
> > > > endianness (as specified in the
> > > > +
> > > > + values[i] = data & 0xFF;
> > > > + values[i+1] = data >> 8;
> > >
> > > this is incorrect; it forces the data to be little endian, however, the
> > > endianness (as specified in the driver's .scan_type) is IIO_CPU -- the
> > > code breaks for
inux-kernel@vger.kernel.org; Pandruvada, Srinivas; Reus, Adriana
> > Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in
> > trigger handler
> >
> >
> > > Reading all axis values in one i2c transfer reduces the delays
> > > i
/2] iio: accel: kxcjk-1013: optimize i2c transfers in
> trigger handler
>
>
> > Reading all axis values in one i2c transfer reduces the delays
> > introduced by the i2c bus. In case i2c block read is not supported,
> > fallback to reading each axis as a separat
-Original Message-
From: Peter Meerwald [mailto:pme...@pmeerw.net]
Sent: 16 February, 2015 21:26
To: Tirdea, Irina
Cc: Jonathan Cameron; linux-...@vger.kernel.org;
linux-kernel@vger.kernel.org; Pandruvada, Srinivas; Reus, Adriana
Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013
; Reus, Adriana
Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in
trigger handler
Reading all axis values in one i2c transfer reduces the delays
introduced by the i2c bus. In case i2c block read is not supported,
fallback to reading each axis as a separate
+
+ values[i] = data 0xFF;
+ values[i+1] = data 8;
this is incorrect; it forces the data to be little endian, however, the
endianness (as specified in the driver's .scan_type) is IIO_CPU -- the
code breaks for big-endian CPUs
since
On Fri, 2015-02-20 at 16:23 +0100, Peter Meerwald wrote:
+
+ values[i] = data 0xFF;
+ values[i+1] = data 8;
this is incorrect; it forces the data to be little endian, however, the
endianness (as specified in the driver's .scan_type) is IIO_CPU
> Reading all axis values in one i2c transfer reduces the delays
> introduced by the i2c bus. In case i2c block read is not supported,
> fallback to reading each axis as a separate word.
see comments inline below
> Signed-off-by: Adriana Reus
> Signed-off-by: Irina Tirdea
> Reviewed-by:
From: Adriana Reus
Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to
enable/disable the bus at each i2c transfer and must wait for
the enable/disable to happen before sending the data.
When reading data in the trigger handler, the kxcjk-1013 accel driver
does one i2c transfer for
Reading all axis values in one i2c transfer reduces the delays
introduced by the i2c bus. In case i2c block read is not supported,
fallback to reading each axis as a separate word.
see comments inline below
Signed-off-by: Adriana Reus adriana.r...@intel.com
Signed-off-by: Irina Tirdea
From: Adriana Reus adriana.r...@intel.com
Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to
enable/disable the bus at each i2c transfer and must wait for
the enable/disable to happen before sending the data.
When reading data in the trigger handler, the kxcjk-1013 accel driver
does
16 matches
Mail list logo
