Re: [PATCH 2/2] iio: distance: add devantech us ranger srf04

2017-01-29 Thread Lars-Peter Clausen
On 01/29/2017 12:58 AM, Andreas Klinger wrote: > This patch adds support for the ultrasonic ranger srf04 of devantech. Thanks for the patch. Looks mostly good, a few small comments inline. > diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c > new file mode 100644 > index

Re: [PATCH 2/2] iio: distance: add devantech us ranger srf04

2017-01-29 Thread Peter Meerwald-Stadler
> This patch adds support for the ultrasonic ranger srf04 of devantech. comments below > This device is measuring the distance of objects in a range between 1 cm > and 3 meters and a theoretical resolution of 3 mm. > > There are two GPIOs used: > - trigger: set when the measurement should st

[PATCH 2/2] iio: distance: add devantech us ranger srf04

2017-01-28 Thread Andreas Klinger
This patch adds support for the ultrasonic ranger srf04 of devantech. This device is measuring the distance of objects in a range between 1 cm and 3 meters and a theoretical resolution of 3 mm. There are two GPIOs used: - trigger: set when the measurement should start - echo: set when the ult