RE: [PATCH 2/2] iio: inkern: add error case in iio_channel_get()

2012-09-17 Thread Kim, Milo
> Fine, I'm convinced. Certainly less weird doing it your way ;) > Please do fix up the get all case as well. Please refer to chained patches. [PATCH 1/2] iio: inkern: add error case in iio_channel_get() [PATCH 2/2] iio: inkern: put the IIO device when mem alloc gets failed I'd like to mention t

Re: [PATCH 2/2] iio: inkern: add error case in iio_channel_get()

2012-09-14 Thread Jonathan Cameron
On 14/09/12 01:59, Kim, Milo wrote: On 10/09/12 09:02, Kim, Milo wrote: The datasheet name is defined in the IIO driver. On the other hand, the adc_channel_label is configured in the platform machine side. If the datasheet name is not matched with any adc_channel_label, the iio_ch

RE: [PATCH 2/2] iio: inkern: add error case in iio_channel_get()

2012-09-13 Thread Kim, Milo
> On 10/09/12 09:02, Kim, Milo wrote: > > The datasheet name is defined in the IIO driver. > > On the other hand, the adc_channel_label is configured in > > the platform machine side. > > If the datasheet name is not matched with any adc_channel_label, > > the iio_channel_get() should be

Re: [PATCH 2/2] iio: inkern: add error case in iio_channel_get()

2012-09-10 Thread Lars-Peter Clausen
On 09/10/2012 10:02 AM, Kim, Milo wrote: > The datasheet name is defined in the IIO driver. > On the other hand, the adc_channel_label is configured in > the platform machine side. > If the datasheet name is not matched with any adc_channel_label, > the iio_channel_get() should be returned as

Re: [PATCH 2/2] iio: inkern: add error case in iio_channel_get()

2012-09-10 Thread Jonathan Cameron
On 10/09/12 09:02, Kim, Milo wrote: The datasheet name is defined in the IIO driver. On the other hand, the adc_channel_label is configured in the platform machine side. If the datasheet name is not matched with any adc_channel_label, the iio_channel_get() should be returned as error fo

[PATCH 2/2] iio: inkern: add error case in iio_channel_get()

2012-09-10 Thread Kim, Milo
The datasheet name is defined in the IIO driver. On the other hand, the adc_channel_label is configured in the platform machine side. If the datasheet name is not matched with any adc_channel_label, the iio_channel_get() should be returned as error for preventing using invalid IIO channel dat