Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-29 Thread Jonathan Cameron
On Wed, 26 Sep 2018 09:33:53 +0800 Song Qiang wrote: > On Tue, Sep 25, 2018 at 02:30:54PM +0100, Jonathan Cameron wrote: > > On Tue, 25 Sep 2018 11:17:24 +0800 > > Song Qiang wrote: > > > > > PNI RM3100 is a high resolution, large signal immunity magnetometer, > > > composed of 3 single senso

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-29 Thread Jonathan Cameron
On Wed, 26 Sep 2018 16:09:45 +0800 Song Qiang wrote: > On Wed, Sep 26, 2018 at 10:30:34AM +0800, Phil Reid wrote: > > On 26/09/2018 9:49 AM, Song Qiang wrote: > > > On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote: > > > > On 25/09/2018 9:30 PM, Jonathan Cameron wrote: > > > > > >

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-26 Thread Phil Reid
On 26/09/2018 4:09 PM, Song Qiang wrote: On Wed, Sep 26, 2018 at 10:30:34AM +0800, Phil Reid wrote: On 26/09/2018 9:49 AM, Song Qiang wrote: On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote: On 25/09/2018 9:30 PM, Jonathan Cameron wrote: +static irqreturn_t rm3100_trigger_handler(int

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-26 Thread Song Qiang
On Wed, Sep 26, 2018 at 10:30:34AM +0800, Phil Reid wrote: > On 26/09/2018 9:49 AM, Song Qiang wrote: > > On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote: > > > On 25/09/2018 9:30 PM, Jonathan Cameron wrote: > > > > > +static irqreturn_t rm3100_trigger_handler(int irq, void *p) > > > > >

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Phil Reid
On 26/09/2018 9:49 AM, Song Qiang wrote: On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote: On 25/09/2018 9:30 PM, Jonathan Cameron wrote: +static irqreturn_t rm3100_trigger_handler(int irq, void *p) +{ + struct iio_poll_func *pf = p; + struct iio_dev *indio_dev = pf->indio_

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Song Qiang
On Tue, Sep 25, 2018 at 11:20:18PM +0530, Himanshu Jha wrote: > On Tue, Sep 25, 2018 at 11:17:24AM +0800, Song Qiang wrote: > > PNI RM3100 is a high resolution, large signal immunity magnetometer, > > composed of 3 single sensors and a processing chip with MagI2C Interface. > > > > Following funct

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Song Qiang
On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote: > On 25/09/2018 9:30 PM, Jonathan Cameron wrote: > > > +static irqreturn_t rm3100_trigger_handler(int irq, void *p) > > > +{ > > > + struct iio_poll_func *pf = p; > > > + struct iio_dev *indio_dev = pf->indio_dev; > > > + struct rm3100_data

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Song Qiang
On Tue, Sep 25, 2018 at 02:30:54PM +0100, Jonathan Cameron wrote: > On Tue, 25 Sep 2018 11:17:24 +0800 > Song Qiang wrote: > > > PNI RM3100 is a high resolution, large signal immunity magnetometer, > > composed of 3 single sensors and a processing chip with MagI2C Interface. > > > > Following fu

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Himanshu Jha
On Tue, Sep 25, 2018 at 11:17:24AM +0800, Song Qiang wrote: > PNI RM3100 is a high resolution, large signal immunity magnetometer, > composed of 3 single sensors and a processing chip with MagI2C Interface. > > Following functions are available: > - Single-shot measurement from > /sys/bus/iio/de

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Phil Reid
On 25/09/2018 9:30 PM, Jonathan Cameron wrote: +static irqreturn_t rm3100_trigger_handler(int irq, void *p) +{ + struct iio_poll_func *pf = p; + struct iio_dev *indio_dev = pf->indio_dev; + struct rm3100_data *data = iio_priv(indio_dev); + struct regmap *regmap = data->reg

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Jonathan Cameron
On Tue, 25 Sep 2018 11:17:24 +0800 Song Qiang wrote: > PNI RM3100 is a high resolution, large signal immunity magnetometer, > composed of 3 single sensors and a processing chip with MagI2C Interface. > > Following functions are available: > - Single-shot measurement from > /sys/bus/iio/devices

[PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-24 Thread Song Qiang
PNI RM3100 is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip with MagI2C Interface. Following functions are available: - Single-shot measurement from /sys/bus/iio/devices/iio:deviceX/in_magn_{axis}_raw - Triggerd buffer measurement. - Bo