Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-20 Thread Benjamin Tissoires
On Wed, Dec 20, 2017 at 7:20 PM, Dmitry Torokhov wrote: > On Wed, Dec 20, 2017 at 9:11 AM, Benjamin Tissoires > wrote: >> On Sat, Dec 16, 2017 at 1:48 AM, Dmitry Torokhov >> wrote: >>> Hi Benjamin, >>> >>> On

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-20 Thread Benjamin Tissoires
On Wed, Dec 20, 2017 at 7:20 PM, Dmitry Torokhov wrote: > On Wed, Dec 20, 2017 at 9:11 AM, Benjamin Tissoires > wrote: >> On Sat, Dec 16, 2017 at 1:48 AM, Dmitry Torokhov >> wrote: >>> Hi Benjamin, >>> >>> On Thu, Dec 14, 2017 at 02:25:22PM +0100, Benjamin Tissoires wrote: Before

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-20 Thread Dmitry Torokhov
On Wed, Dec 20, 2017 at 9:11 AM, Benjamin Tissoires wrote: > On Sat, Dec 16, 2017 at 1:48 AM, Dmitry Torokhov > wrote: >> Hi Benjamin, >> >> On Thu, Dec 14, 2017 at 02:25:22PM +0100, Benjamin Tissoires wrote: >>> Before unregistering the

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-20 Thread Dmitry Torokhov
On Wed, Dec 20, 2017 at 9:11 AM, Benjamin Tissoires wrote: > On Sat, Dec 16, 2017 at 1:48 AM, Dmitry Torokhov > wrote: >> Hi Benjamin, >> >> On Thu, Dec 14, 2017 at 02:25:22PM +0100, Benjamin Tissoires wrote: >>> Before unregistering the led classes, we have to be sure there is no >>> more

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-20 Thread Benjamin Tissoires
On Sat, Dec 16, 2017 at 1:48 AM, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Dec 14, 2017 at 02:25:22PM +0100, Benjamin Tissoires wrote: >> Before unregistering the led classes, we have to be sure there is no >> more events in the input pipeline. >> Closing the

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-20 Thread Benjamin Tissoires
On Sat, Dec 16, 2017 at 1:48 AM, Dmitry Torokhov wrote: > Hi Benjamin, > > On Thu, Dec 14, 2017 at 02:25:22PM +0100, Benjamin Tissoires wrote: >> Before unregistering the led classes, we have to be sure there is no >> more events in the input pipeline. >> Closing the input node before removing

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-15 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Dec 14, 2017 at 02:25:22PM +0100, Benjamin Tissoires wrote: > Before unregistering the led classes, we have to be sure there is no > more events in the input pipeline. > Closing the input node before removing the led classes flushes the > pipeline and this prevents segfaults.

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-15 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Dec 14, 2017 at 02:25:22PM +0100, Benjamin Tissoires wrote: > Before unregistering the led classes, we have to be sure there is no > more events in the input pipeline. > Closing the input node before removing the led classes flushes the > pipeline and this prevents segfaults.

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-14 Thread Samuel Thibault
Benjamin Tissoires, on jeu. 14 déc. 2017 14:25:22 +0100, wrote: > Before unregistering the led classes, we have to be sure there is no > more events in the input pipeline. > Closing the input node before removing the led classes flushes the > pipeline and this prevents segfaults. > > Found with

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-14 Thread Samuel Thibault
Benjamin Tissoires, on jeu. 14 déc. 2017 14:25:22 +0100, wrote: > Before unregistering the led classes, we have to be sure there is no > more events in the input pipeline. > Closing the input node before removing the led classes flushes the > pipeline and this prevents segfaults. > > Found with

[PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-14 Thread Benjamin Tissoires
Before unregistering the led classes, we have to be sure there is no more events in the input pipeline. Closing the input node before removing the led classes flushes the pipeline and this prevents segfaults. Found with https://github.com/whot/fuzzydevice Link:

[PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-14 Thread Benjamin Tissoires
Before unregistering the led classes, we have to be sure there is no more events in the input pipeline. Closing the input node before removing the led classes flushes the pipeline and this prevents segfaults. Found with https://github.com/whot/fuzzydevice Link: