Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread Rene Herman
On 17-02-08 04:56, H. Peter Anvin wrote: Rene Herman wrote: On 16-02-08 20:01, H. Peter Anvin wrote: Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Whoa... Are you sure this is correct? !likely(x) is equivalent to unlikely(!x) Not with respe

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread H. Peter Anvin
Rene Herman wrote: On 16-02-08 20:01, H. Peter Anvin wrote: Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Whoa... Are you sure this is correct? !likely(x) is equivalent to unlikely(!x) Not with respect to its value I believe? likely(x) == !!(

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread Rene Herman
On 16-02-08 20:01, H. Peter Anvin wrote: Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Whoa... Are you sure this is correct? !likely(x) is equivalent to unlikely(!x) Not with respect to its value I believe? likely(x) == !!(x), and unlikely(!x

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
H. Peter Anvin wrote: > Roel Kluin wrote: >> H. Peter Anvin wrote: >>> Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) >>> Whoa... >>> >>> Are you sure this is correct? >>> >>> !likely(x) is equivalent to unlikely(!x), not the opposite, so

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread H. Peter Anvin
Roel Kluin wrote: H. Peter Anvin wrote: Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Whoa... Are you sure this is correct? !likely(x) is equivalent to unlikely(!x), not the opposite, so this is a functional change... You are right, sorry, Nee

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
H. Peter Anvin wrote: > Roel Kluin wrote: >> Not entirely sure who to send this to >> --- >> Replace !likely(x) by likely(!x) > > Whoa... > > Are you sure this is correct? > > !likely(x) is equivalent to unlikely(!x), not the opposite, so this is a > functional change... > > -hpa > You are

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread H. Peter Anvin
Roel Kluin wrote: Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Whoa... Are you sure this is correct? !likely(x) is equivalent to unlikely(!x), not the opposite, so this is a functional change... -hpa -- To unsubscribe from this list: send the line "uns

[PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

2008-02-16 Thread Roel Kluin
Not entirely sure who to send this to --- Replace !likely(x) by likely(!x) Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/kernel/exit.c b/kernel/exit.c index 506a957..df207fc 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1497,7 +1497,7 @@ repeat: