Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-16 Thread Kees Cook
On Tue, Apr 16, 2019 at 10:21 PM Kees Cook wrote: > > On Mon, Apr 8, 2019 at 5:09 PM Matteo Croce wrote: > > > > Use the shared variables for range check, instead of declaring a local one > > in every source file. > > > > Signed-off-by: Matteo Croce > > --- > > kernel/pid_namespace.c | 3 +- >

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-16 Thread Kees Cook
On Mon, Apr 8, 2019 at 5:09 PM Matteo Croce wrote: > > Use the shared variables for range check, instead of declaring a local one > in every source file. > > Signed-off-by: Matteo Croce > --- > kernel/pid_namespace.c | 3 +- > kernel/sysctl.c| 193 --

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-16 Thread Andrew Morton
On Wed, 10 Apr 2019 15:59:55 -0700 Kees Cook wrote: > On Wed, Apr 10, 2019 at 3:54 PM Matteo Croce wrote: > > > > On Thu, Apr 11, 2019 at 12:34 AM Kees Cook wrote: > > > > > > On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce wrote: > > > > > > > > FYI, this are the stats from my local repo, just t

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 3:54 PM Matteo Croce wrote: > > On Thu, Apr 11, 2019 at 12:34 AM Kees Cook wrote: > > > > On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce wrote: > > > > > > FYI, this are the stats from my local repo, just to let you the size > > > of a series with all the changes in it: > >

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Matteo Croce
On Thu, Apr 11, 2019 at 12:34 AM Kees Cook wrote: > > On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce wrote: > > > > FYI, this are the stats from my local repo, just to let you the size > > of a series with all the changes in it: > > > > $ git --no-pager log --stat --oneline linus/master > > 2 file

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce wrote: > > On Wed, Apr 10, 2019 at 11:51 PM Kees Cook wrote: > > > > On Wed, Apr 10, 2019 at 12:24 PM Matteo Croce wrote: > > > > > > On Wed, Apr 10, 2019 at 8:46 PM Kees Cook wrote: > > > > > > > > On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce wrote:

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Matteo Croce
On Wed, Apr 10, 2019 at 11:51 PM Kees Cook wrote: > > On Wed, Apr 10, 2019 at 12:24 PM Matteo Croce wrote: > > > > On Wed, Apr 10, 2019 at 8:46 PM Kees Cook wrote: > > > > > > On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce wrote: > > > > > > > > Use the shared variables for range check, instead of

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 12:24 PM Matteo Croce wrote: > > On Wed, Apr 10, 2019 at 8:46 PM Kees Cook wrote: > > > > On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce wrote: > > > > > > Use the shared variables for range check, instead of declaring a local one > > > in every source file. > > > > I was ex

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Matteo Croce
On Wed, Apr 10, 2019 at 8:46 PM Kees Cook wrote: > > On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce wrote: > > > > Use the shared variables for range check, instead of declaring a local one > > in every source file. > > I was expecting this to be a tree-wide change for all the cases found > by patch

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Kees Cook
On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce wrote: > > Use the shared variables for range check, instead of declaring a local one > in every source file. I was expecting this to be a tree-wide change for all the cases found by patch 1's "git grep". Slight change to the grep for higher accuracy:

[PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-08 Thread Matteo Croce
Use the shared variables for range check, instead of declaring a local one in every source file. Signed-off-by: Matteo Croce --- kernel/pid_namespace.c | 3 +- kernel/sysctl.c| 193 - kernel/ucount.c| 6 +- 3 files changed, 98 insertion