Re: Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-04 Thread Masami Hiramatsu
On 2015/06/03 6:55, Andy Lutomirski wrote: > On Tue, Jun 2, 2015 at 2:46 PM, Masami Hiramatsu > wrote: >> On 2015/06/02 14:44, Ingo Molnar wrote: >>> >>> * Masami Hiramatsu wrote: >>> On 2015/06/02 2:04, Andy Lutomirski wrote: > On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin > wro

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-03 Thread Ingo Molnar
* Masami Hiramatsu wrote: > On 2015/06/02 14:44, Ingo Molnar wrote: > > > > * Masami Hiramatsu wrote: > > > >> On 2015/06/02 2:04, Andy Lutomirski wrote: > >>> On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin > >>> wrote: > Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max inst

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 2:46 PM, Masami Hiramatsu wrote: > On 2015/06/02 14:44, Ingo Molnar wrote: >> >> * Masami Hiramatsu wrote: >> >>> On 2015/06/02 2:04, Andy Lutomirski wrote: On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin wrote: > Commit 91e5ed49fca0 ("x86/asm/decoder: Fix a

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-02 Thread Masami Hiramatsu
On 2015/06/02 14:44, Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> On 2015/06/02 2:04, Andy Lutomirski wrote: >>> On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin >>> wrote: Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction size in the insn decoder") has c

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-02 Thread Masami Hiramatsu
On 2015/06/02 6:57, Andy Lutomirski wrote: > On Mon, Jun 1, 2015 at 2:49 PM, Masami Hiramatsu > wrote: >> On 2015/06/02 2:04, Andy Lutomirski wrote: >>> On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin >>> wrote: Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction siz

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Ingo Molnar
* Eugene Shatokhin wrote: > Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction > size in the insn decoder") has changed MAX_INSN_SIZE from 16 to 15 bytes > on x86. > > As a side effect, the slots Kprobes use to store the instructions became > 1 byte shorter. This is unfortun

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Ingo Molnar
* Masami Hiramatsu wrote: > On 2015/06/02 2:04, Andy Lutomirski wrote: > > On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin > > wrote: > >> Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction > >> size in the insn decoder") has changed MAX_INSN_SIZE from 16 to 15 bytes > >> o

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Andy Lutomirski
On Mon, Jun 1, 2015 at 2:49 PM, Masami Hiramatsu wrote: > On 2015/06/02 2:04, Andy Lutomirski wrote: >> On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin >> wrote: >>> Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction >>> size in the insn decoder") has changed MAX_INSN_SIZE fr

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Masami Hiramatsu
On 2015/06/02 1:32, Eugene Shatokhin wrote: > Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction > size in the insn decoder") has changed MAX_INSN_SIZE from 16 to 15 bytes > on x86. > > As a side effect, the slots Kprobes use to store the instructions became > 1 byte shorter. T

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Masami Hiramatsu
On 2015/06/02 2:04, Andy Lutomirski wrote: > On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin > wrote: >> Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction >> size in the insn decoder") has changed MAX_INSN_SIZE from 16 to 15 bytes >> on x86. >> >> As a side effect, the slots

Re: [PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Andy Lutomirski
On Mon, Jun 1, 2015 at 9:32 AM, Eugene Shatokhin wrote: > Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction > size in the insn decoder") has changed MAX_INSN_SIZE from 16 to 15 bytes > on x86. > > As a side effect, the slots Kprobes use to store the instructions became > 1 byt

[PATCH 2/2] kprobes/x86: Use 16 bytes for each instruction slot again

2015-06-01 Thread Eugene Shatokhin
Commit 91e5ed49fca0 ("x86/asm/decoder: Fix and enforce max instruction size in the insn decoder") has changed MAX_INSN_SIZE from 16 to 15 bytes on x86. As a side effect, the slots Kprobes use to store the instructions became 1 byte shorter. This is unfortunate because, for example, the Kprobes' "b