Re: [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again

2020-10-27 Thread SeongJae Park
On Mon, 26 Oct 2020 13:44:33 -0700 Brendan Higgins wrote: > On Sun, Oct 25, 2020 at 5:45 AM wrote: > > > > On Thu, Oct 22, 2020 at 08:35:26AM +0200, SeongJae Park wrote: > > > On Wed, 21 Oct 2020 14:32:52 -0700 Brendan Higgins > > > wrote: > > > > > > > On Mon, Oct 12, 2020 at 3:27 AM

Re: [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again

2020-10-26 Thread Brendan Higgins
On Sun, Oct 25, 2020 at 5:45 AM wrote: > > On Thu, Oct 22, 2020 at 08:35:26AM +0200, SeongJae Park wrote: > > On Wed, 21 Oct 2020 14:32:52 -0700 Brendan Higgins > > wrote: > > > > > On Mon, Oct 12, 2020 at 3:27 AM SeongJae Park wrote: > > > > > > > > From: SeongJae Park > > > > > > > >

Re: [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again

2020-10-25 Thread andy
On Thu, Oct 22, 2020 at 08:35:26AM +0200, SeongJae Park wrote: > On Wed, 21 Oct 2020 14:32:52 -0700 Brendan Higgins > wrote: > > > On Mon, Oct 12, 2020 at 3:27 AM SeongJae Park wrote: > > > > > > From: SeongJae Park > > > > > > 'kunit_kernel.kunittest_config' was constant at first, and

Re: [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again

2020-10-22 Thread SeongJae Park
On Wed, 21 Oct 2020 14:32:52 -0700 Brendan Higgins wrote: > On Mon, Oct 12, 2020 at 3:27 AM SeongJae Park wrote: > > > > From: SeongJae Park > > > > 'kunit_kernel.kunittest_config' was constant at first, and therefore it > > used UPPER_SNAKE_CASE naming convention that usually means it is > >

Re: [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again

2020-10-21 Thread Brendan Higgins
On Mon, Oct 12, 2020 at 3:27 AM SeongJae Park wrote: > > From: SeongJae Park > > 'kunit_kernel.kunittest_config' was constant at first, and therefore it > used UPPER_SNAKE_CASE naming convention that usually means it is > constant in Python world. But, commit e3212513a8f0 ("kunit: Create >

Re: [PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again

2020-10-20 Thread SeongJae Park
ping On Mon, 12 Oct 2020 12:26:21 +0200 SeongJae Park wrote: > From: SeongJae Park > > 'kunit_kernel.kunittest_config' was constant at first, and therefore it > used UPPER_SNAKE_CASE naming convention that usually means it is > constant in Python world. But, commit e3212513a8f0 ("kunit:

[PATCH 2/2] kunit: tool: Mark 'kunittest_config' as constant again

2020-10-12 Thread SeongJae Park
From: SeongJae Park 'kunit_kernel.kunittest_config' was constant at first, and therefore it used UPPER_SNAKE_CASE naming convention that usually means it is constant in Python world. But, commit e3212513a8f0 ("kunit: Create default config in '--build_dir'") made it modifiable to fix a use case