Hi Florian and Pavel,
On 06/27/2016 07:46 AM, Florian Vaussard wrote:
Hi Pavel,
Le 26. 06. 16 à 23:49, Pavel Machek a écrit :
Hi!
+struct ncp5623_led {
+ bool active;
+ unsigned int led_no;
+ struct led_classdev ldev;
+ struct work_struct work;
+ struct
Hi Florian and Pavel,
On 06/27/2016 07:46 AM, Florian Vaussard wrote:
Hi Pavel,
Le 26. 06. 16 à 23:49, Pavel Machek a écrit :
Hi!
+struct ncp5623_led {
+ bool active;
+ unsigned int led_no;
+ struct led_classdev ldev;
+ struct work_struct work;
+ struct
Hi Pavel,
Le 26. 06. 16 à 23:49, Pavel Machek a écrit :
> Hi!
>
>>> +struct ncp5623_led {
>>> + bool active;
>>> + unsigned int led_no;
>>> + struct led_classdev ldev;
>>> + struct work_struct work;
>>> + struct ncp5623_priv *priv;
>>> +};
>>> +
>>> +struct ncp5623_priv {
>>> +
Hi Pavel,
Le 26. 06. 16 à 23:49, Pavel Machek a écrit :
> Hi!
>
>>> +struct ncp5623_led {
>>> + bool active;
>>> + unsigned int led_no;
>>> + struct led_classdev ldev;
>>> + struct work_struct work;
>>> + struct ncp5623_priv *priv;
>>> +};
>>> +
>>> +struct ncp5623_priv {
>>> +
Hi!
> >+struct ncp5623_led {
> >+bool active;
> >+unsigned int led_no;
> >+struct led_classdev ldev;
> >+struct work_struct work;
> >+struct ncp5623_priv *priv;
> >+};
> >+
> >+struct ncp5623_priv {
> >+struct ncp5623_led leds[NCP5623_MAX_LEDS];
>
> Please allocate memory
Hi!
> >+struct ncp5623_led {
> >+bool active;
> >+unsigned int led_no;
> >+struct led_classdev ldev;
> >+struct work_struct work;
> >+struct ncp5623_priv *priv;
> >+};
> >+
> >+struct ncp5623_priv {
> >+struct ncp5623_led leds[NCP5623_MAX_LEDS];
>
> Please allocate memory
Hi Florian,
On 06/22/2016 08:08 AM, Florian Vaussard wrote:
Hi Jacek,
Le 21. 06. 16 à 17:29, Jacek Anaszewski a écrit :
Hi Florian,
Thanks for the patch. Please refer to my comments in the code.
Thanks for your review. I completely agree with you, I will address your
comments in V2. I
Hi Florian,
On 06/22/2016 08:08 AM, Florian Vaussard wrote:
Hi Jacek,
Le 21. 06. 16 à 17:29, Jacek Anaszewski a écrit :
Hi Florian,
Thanks for the patch. Please refer to my comments in the code.
Thanks for your review. I completely agree with you, I will address your
comments in V2. I
Hi Jacek,
Le 21. 06. 16 à 17:29, Jacek Anaszewski a écrit :
> Hi Florian,
>
> Thanks for the patch. Please refer to my comments in the code.
>
Thanks for your review. I completely agree with you, I will address your
comments in V2. I just have one small question below.
> On 06/21/2016 09:29
Hi Jacek,
Le 21. 06. 16 à 17:29, Jacek Anaszewski a écrit :
> Hi Florian,
>
> Thanks for the patch. Please refer to my comments in the code.
>
Thanks for your review. I completely agree with you, I will address your
comments in V2. I just have one small question below.
> On 06/21/2016 09:29
Hi Florian,
Thanks for the patch. Please refer to my comments in the code.
On 06/21/2016 09:29 AM, Florian Vaussard wrote:
The NCP5623 is a 3-channel LED driver from On Semiconductor controlled
through I2C. The PWM of each channel can be independently set with 32
distinct levels. In addition,
Hi Florian,
Thanks for the patch. Please refer to my comments in the code.
On 06/21/2016 09:29 AM, Florian Vaussard wrote:
The NCP5623 is a 3-channel LED driver from On Semiconductor controlled
through I2C. The PWM of each channel can be independently set with 32
distinct levels. In addition,
The NCP5623 is a 3-channel LED driver from On Semiconductor controlled
through I2C. The PWM of each channel can be independently set with 32
distinct levels. In addition, the intensity of the current source can be
globally set using an external bias resistor fixing the reference
current (Iref) and
The NCP5623 is a 3-channel LED driver from On Semiconductor controlled
through I2C. The PWM of each channel can be independently set with 32
distinct levels. In addition, the intensity of the current source can be
globally set using an external bias resistor fixing the reference
current (Iref) and
14 matches
Mail list logo
