Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-13 Thread Jacek Anaszewski
Hi Vesa, On 1/9/19 8:11 AM, Vesa Jääskeläinen wrote: Hi Pavel, On 09/01/2019 0.59, Pavel Machek wrote: Hi! Grab yourself an RGB LED and play with it; you'll see what the problems are. It is hard to explain colors over email... Video [0] gives some overview of lp5024 capabilities. I don't

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-13 Thread Jacek Anaszewski
Hi Vesa, On 1/9/19 7:46 AM, Vesa Jääskeläinen wrote: Hi Jacek, On 07/01/2019 23.13, Jacek Anaszewski wrote: Hi Vesa, On 1/5/19 1:39 AM, Vesa Jääskeläinen wrote: Hi Jacek, On 04/01/2019 23.37, Jacek Anaszewski wrote: But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTN

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-10 Thread Dan Murphy
On 1/10/19 3:02 PM, Jacek Anaszewski wrote: > On 1/10/19 8:58 PM, Dan Murphy wrote: >> On 1/10/19 1:23 PM, Jacek Anaszewski wrote: >>> Dan, >>> >>> On 1/10/19 1:46 PM, Dan Murphy wrote: Jacek On 1/8/19 3:25 PM, Dan Murphy wrote: > Jacek > > On 1/8/19 3:18 PM, Jacek Anasze

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-10 Thread Jacek Anaszewski
On 1/10/19 8:58 PM, Dan Murphy wrote: On 1/10/19 1:23 PM, Jacek Anaszewski wrote: Dan, On 1/10/19 1:46 PM, Dan Murphy wrote: Jacek On 1/8/19 3:25 PM, Dan Murphy wrote: Jacek On 1/8/19 3:18 PM, Jacek Anaszewski wrote: Hi Dan, On 1/7/19 10:14 PM, Dan Murphy wrote: Jacek On 1/7/19 2:59 PM,

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-10 Thread Dan Murphy
On 1/10/19 1:23 PM, Jacek Anaszewski wrote: > Dan, > > On 1/10/19 1:46 PM, Dan Murphy wrote: >> Jacek >> >> On 1/8/19 3:25 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 1/8/19 3:18 PM, Jacek Anaszewski wrote: Hi Dan, On 1/7/19 10:14 PM, Dan Murphy wrote: > Jacek > > On 1/7/

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-10 Thread Jacek Anaszewski
Dan, On 1/10/19 1:46 PM, Dan Murphy wrote: Jacek On 1/8/19 3:25 PM, Dan Murphy wrote: Jacek On 1/8/19 3:18 PM, Jacek Anaszewski wrote: Hi Dan, On 1/7/19 10:14 PM, Dan Murphy wrote: Jacek On 1/7/19 2:59 PM, Jacek Anaszewski wrote: Dan, On 1/7/19 8:36 PM, Dan Murphy wrote: Jacek On 1/7/

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-10 Thread Dan Murphy
Jacek On 1/8/19 3:25 PM, Dan Murphy wrote: > Jacek > > On 1/8/19 3:18 PM, Jacek Anaszewski wrote: >> Hi Dan, >> >> On 1/7/19 10:14 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 1/7/19 2:59 PM, Jacek Anaszewski wrote: Dan, On 1/7/19 8:36 PM, Dan Murphy wrote: > Jacek > > On

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Vesa Jääskeläinen
Hi Pavel, On 09/01/2019 0.59, Pavel Machek wrote: Hi! Grab yourself an RGB LED and play with it; you'll see what the problems are. It is hard to explain colors over email... Video [0] gives some overview of lp5024 capabilities. I don't see any problems in exposing separate red,green,blue fi

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Vesa Jääskeläinen
Hi Jacek, On 07/01/2019 23.13, Jacek Anaszewski wrote: Hi Vesa, On 1/5/19 1:39 AM, Vesa Jääskeläinen wrote: Hi Jacek, On 04/01/2019 23.37, Jacek Anaszewski wrote: But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity via

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Vesa Jääskeläinen
Hi Dan, On 07/01/2019 21.34, Dan Murphy wrote: Vesa On 1/4/19 6:39 PM, Vesa Jääskeläinen wrote: Hi Jacek, On 04/01/2019 23.37, Jacek Anaszewski wrote: But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity via a single re

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Pavel Machek
Hi! > >>>Grab yourself an RGB LED and play with it; you'll see what the > >>>problems are. It is hard to explain colors over email... > >> > >>Video [0] gives some overview of lp5024 capabilities. > >> > >>I don't see any problems in exposing separate red,green,blue > >>files and brightness for th

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Dan Murphy
Jacek On 1/8/19 3:18 PM, Jacek Anaszewski wrote: > Hi Dan, > > On 1/7/19 10:14 PM, Dan Murphy wrote: >> Jacek >> >> On 1/7/19 2:59 PM, Jacek Anaszewski wrote: >>> Dan, >>> >>> On 1/7/19 8:36 PM, Dan Murphy wrote: Jacek On 1/7/19 1:13 PM, Jacek Anaszewski wrote: > On 1/6/19 4:52

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Dan Murphy
Jacek Thanks for the review. v2 will contain the LP5030/36 as well. On 1/8/19 3:10 PM, Jacek Anaszewski wrote: > Dan, > > On 12/19/18 5:26 PM, Dan Murphy wrote: >> Introduce the LP5024 and LP5018 RGB LED driver. >> The difference in these 2 parts are only in the number of >> LED outputs where t

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Jacek Anaszewski
Hi Dan, On 1/7/19 10:14 PM, Dan Murphy wrote: Jacek On 1/7/19 2:59 PM, Jacek Anaszewski wrote: Dan, On 1/7/19 8:36 PM, Dan Murphy wrote: Jacek On 1/7/19 1:13 PM, Jacek Anaszewski wrote: On 1/6/19 4:52 PM, Jacek Anaszewski wrote: Hi Pavel, On 1/5/19 11:12 PM, Pavel Machek wrote: Hi! Gr

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-08 Thread Jacek Anaszewski
Dan, On 12/19/18 5:26 PM, Dan Murphy wrote: Introduce the LP5024 and LP5018 RGB LED driver. The difference in these 2 parts are only in the number of LED outputs where the LP5024 can control 24 LEDs the LP5018 can only control 18. The device has the ability to group LED output into control bank

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-07 Thread Dan Murphy
Jacek On 1/7/19 3:13 PM, Jacek Anaszewski wrote: > Hi Vesa, > > On 1/5/19 1:39 AM, Vesa Jääskeläinen wrote: >> Hi Jacek, >> >> On 04/01/2019 23.37, Jacek Anaszewski wrote: >>> But, aside from that hypothetic issue, we need a solution for >>> LEDn_BRIGHTNESS feature of lp5024, i.e. setting color i

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-07 Thread Dan Murphy
Jacek On 1/7/19 2:59 PM, Jacek Anaszewski wrote: > Dan, > > On 1/7/19 8:36 PM, Dan Murphy wrote: >> Jacek >> >> On 1/7/19 1:13 PM, Jacek Anaszewski wrote: >>> On 1/6/19 4:52 PM, Jacek Anaszewski wrote: Hi Pavel, On 1/5/19 11:12 PM, Pavel Machek wrote: > Hi! > >>> Grab y

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-07 Thread Jacek Anaszewski
Hi Vesa, On 1/5/19 1:39 AM, Vesa Jääskeläinen wrote: Hi Jacek, On 04/01/2019 23.37, Jacek Anaszewski wrote: But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity via a single register write. How would you propose to addres

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-07 Thread Jacek Anaszewski
Dan, On 1/7/19 8:36 PM, Dan Murphy wrote: Jacek On 1/7/19 1:13 PM, Jacek Anaszewski wrote: On 1/6/19 4:52 PM, Jacek Anaszewski wrote: Hi Pavel, On 1/5/19 11:12 PM, Pavel Machek wrote: Hi! Grab yourself an RGB LED and play with it; you'll see what the problems are. It is hard to explain co

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-07 Thread Dan Murphy
Jacek On 1/7/19 1:13 PM, Jacek Anaszewski wrote: > On 1/6/19 4:52 PM, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 1/5/19 11:12 PM, Pavel Machek wrote: >>> Hi! >>> > Grab yourself an RGB LED and play with it; you'll see what the > problems are. It is hard to explain colors over email... >

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-07 Thread Dan Murphy
Vesa On 1/4/19 6:39 PM, Vesa Jääskeläinen wrote: > Hi Jacek, > > On 04/01/2019 23.37, Jacek Anaszewski wrote: >> But, aside from that hypothetic issue, we need a solution for >> LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity >> via a single register write. How would you propose t

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-07 Thread Jacek Anaszewski
On 1/6/19 4:52 PM, Jacek Anaszewski wrote: Hi Pavel, On 1/5/19 11:12 PM, Pavel Machek wrote: Hi! Grab yourself an RGB LED and play with it; you'll see what the problems are. It is hard to explain colors over email... Video [0] gives some overview of lp5024 capabilities. I don't see any pro

Re: Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-06 Thread Jacek Anaszewski
Hi Pavel, On 1/5/19 11:12 PM, Pavel Machek wrote: Hi! Grab yourself an RGB LED and play with it; you'll see what the problems are. It is hard to explain colors over email... Video [0] gives some overview of lp5024 capabilities. I don't see any problems in exposing separate red,green,blue fi

Generic RGB LED support was Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-05 Thread Pavel Machek
Hi! > >Grab yourself an RGB LED and play with it; you'll see what the > >problems are. It is hard to explain colors over email... > > Video [0] gives some overview of lp5024 capabilities. > > I don't see any problems in exposing separate red,green,blue > files and brightness for the devices with

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-05 Thread Jacek Anaszewski
On 1/5/19 1:31 PM, Pavel Machek wrote: We will need to solve RGB leds somehow, hopefully this is solved with it. When? With this attitude we will procrastinate it forever. It's been almost 3 years since first HSV patches. I proposed rough design of LED RGB class interface in [0]. If you find i

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-05 Thread Pavel Machek
> >We will need to solve RGB leds somehow, hopefully this is solved with > >it. > > When? With this attitude we will procrastinate it forever. > It's been almost 3 years since first HSV patches. > > I proposed rough design of LED RGB class interface in [0]. > If you find it totally flawed, then p

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-05 Thread Jacek Anaszewski
Hi Pavel, On 1/4/19 11:07 PM, Pavel Machek wrote: Hi! But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity via a single register write. How would you propose to address that? So they have hardware feature that allows co

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Vesa Jääskeläinen
Hi Jacek, On 04/01/2019 23.37, Jacek Anaszewski wrote: But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity via a single register write. How would you propose to address that? You could model it to something like this in

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Pavel Machek
Hi! > But, aside from that hypothetic issue, we need a solution for > LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity > via a single register write. How would you propose to address that? So they have hardware feature that allows control of 3 LEDs at the same time, right? Actuall

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Jacek Anaszewski
On 1/4/19 9:12 PM, Pavel Machek wrote: Hi! I suppose if one would just make it an array of values (separated by space) and then one file with string array of color element names and on file with maximum value array it could be within those words. The it would be something like: $ echo "23 54

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Pavel Machek
Hi! > >And... LEDs are linear-enough as it is. That is not a problem. But RGB > >does _not_ expect linear response. That's why colors are _way_ off currently. > > Example what I was given was some LEDs are off for let's say 20% of PWM > linearity and then there is non-linear curve for PWM value v

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Pavel Machek
Hi! > >I suppose if one would just make it an array of values (separated by > >space) and then one file with string array of color element names and on > >file with maximum value array it could be within those words. > > > >The it would be something like: > > > >$ echo "23 54 32" > color > > Go a

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Vesa Jääskeläinen
Hi Pavel, On 04/01/2019 1.34, Pavel Machek wrote: Hi! Regarding led_scale_color_elements() - I checked it in GIMP and the results are not satisfactory when increasing brightness. Even if we managed to fix it, the result would not be guaranteed to be the same across all devices. No and they w

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Jacek Anaszewski
Hi Vesa, On 1/4/19 12:19 AM, Vesa Jääskeläinen wrote: Hi Jacek, Comments below. On 04/01/2019 0.05, Jacek Anaszewski wrote: Hi Vesa, Thank you for sharing your ideas. Please find my comment below. On 1/1/19 2:45 PM, Vesa Jääskeläinen wrote: Hi All, On 20/12/2018 14.40, Vesa Jääskeläinen

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-03 Thread Pavel Machek
Hi! > >Regarding led_scale_color_elements() - I checked it in GIMP and > >the results are not satisfactory when increasing brightness. > >Even if we managed to fix it, the result would not be guaranteed > >to be the same across all devices. > > No and they will never be the same. I was told by ou

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-03 Thread Vesa Jääskeläinen
Hi Jacek, Comments below. On 04/01/2019 0.05, Jacek Anaszewski wrote: Hi Vesa, Thank you for sharing your ideas. Please find my comment below. On 1/1/19 2:45 PM, Vesa Jääskeläinen wrote: Hi All, On 20/12/2018 14.40, Vesa Jääskeläinen wrote: Idea was to define preset colors in device tree a

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-03 Thread Jacek Anaszewski
Hi Vesa, Thank you for sharing your ideas. Please find my comment below. On 1/1/19 2:45 PM, Vesa Jääskeläinen wrote: Hi All, On 20/12/2018 14.40, Vesa Jääskeläinen wrote: Idea was to define preset colors in device tree as an example when you are dealing with multi-color LEDs without PWM. In

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-01 Thread Jacek Anaszewski
On 1/1/19 7:11 PM, Dan Murphy wrote: Jacek Thanks for the reply! All Happy New Year! Happy New Year! On 1/1/19 8:42 AM, Jacek Anaszewski wrote: On 12/31/18 8:15 PM, Dan Murphy wrote: On 12/31/18 9:47 AM, Jacek Anaszewski wrote: On 12/31/18 4:43 PM, Jacek Anaszewski wrote: On 12/30/18 6

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-01 Thread Dan Murphy
Jacek Thanks for the reply! All Happy New Year! On 1/1/19 8:42 AM, Jacek Anaszewski wrote: > On 12/31/18 8:15 PM, Dan Murphy wrote: >> On 12/31/18 9:47 AM, Jacek Anaszewski wrote: >>> On 12/31/18 4:43 PM, Jacek Anaszewski wrote: On 12/30/18 6:35 PM, Pavel Machek wrote: > On Sun 2018-12

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-01 Thread Jacek Anaszewski
On 12/31/18 8:15 PM, Dan Murphy wrote: On 12/31/18 9:47 AM, Jacek Anaszewski wrote: On 12/31/18 4:43 PM, Jacek Anaszewski wrote: On 12/30/18 6:35 PM, Pavel Machek wrote: On Sun 2018-12-30 18:09:35, Jacek Anaszewski wrote: On 12/29/18 8:07 PM, Pavel Machek wrote: Hi! With the "color" sysfs

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-01 Thread Jacek Anaszewski
Hi Pavel, On 12/31/18 5:28 PM, Pavel Machek wrote: Hi! There is still HSV approach [0] in store. One problem with proposed implementation is fixed algorithm of RGB <-> HSV color space conversion. Maybe allowing for some board specific adjustments in DT would add more flexibility. [0] https://

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-01 Thread Vesa Jääskeläinen
Hi All, On 20/12/2018 14.40, Vesa Jääskeläinen wrote: Idea was to define preset colors in device tree as an example when you are dealing with multi-color LEDs without PWM. In that case you only have GPIOs to control and then have a problem what does those GPIO's mean. With preset definitions

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-31 Thread Dan Murphy
On 12/31/18 9:47 AM, Jacek Anaszewski wrote: > On 12/31/18 4:43 PM, Jacek Anaszewski wrote: >> On 12/30/18 6:35 PM, Pavel Machek wrote: >>> On Sun 2018-12-30 18:09:35, Jacek Anaszewski wrote: On 12/29/18 8:07 PM, Pavel Machek wrote: > Hi! > With the "color" sysfs file it will

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-31 Thread Pavel Machek
Hi! > There is still HSV approach [0] in store. One problem with proposed > implementation is fixed algorithm of RGB <-> HSV color space conversion. > Maybe allowing for some board specific adjustments in DT would add > more flexibility. > > [0] https://lkml.org/lkml/2017/

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-31 Thread Jacek Anaszewski
On 12/31/18 4:43 PM, Jacek Anaszewski wrote: On 12/30/18 6:35 PM, Pavel Machek wrote: On Sun 2018-12-30 18:09:35, Jacek Anaszewski wrote: On 12/29/18 8:07 PM, Pavel Machek wrote: Hi! With the "color" sysfs file it will make more sense to allow for user defined color palettes. I think def

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-31 Thread Jacek Anaszewski
On 12/30/18 6:35 PM, Pavel Machek wrote: On Sun 2018-12-30 18:09:35, Jacek Anaszewski wrote: On 12/29/18 8:07 PM, Pavel Machek wrote: Hi! With the "color" sysfs file it will make more sense to allow for user defined color palettes. I think defining these values in the device tree or acpi s

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-30 Thread Pavel Machek
On Sun 2018-12-30 18:09:35, Jacek Anaszewski wrote: > On 12/29/18 8:07 PM, Pavel Machek wrote: > >Hi! > > > With the "color" sysfs file it will make more sense to allow for user > defined color palettes. > > >>> > >>>I think defining these values in the device tree or acpi severely lim

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-30 Thread Jacek Anaszewski
On 12/29/18 8:07 PM, Pavel Machek wrote: Hi! With the "color" sysfs file it will make more sense to allow for user defined color palettes. I think defining these values in the device tree or acpi severely limits the devices capabilities. Especially in development phases. If the knobs were

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-29 Thread Pavel Machek
Hi! > >>With the "color" sysfs file it will make more sense to allow for user > >>defined color palettes. > >> > > > >I think defining these values in the device tree or acpi severely limits the > >devices > >capabilities. Especially in development phases. If the knobs were exposed > >then the

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-29 Thread Jacek Anaszewski
On 12/21/18 2:05 PM, Dan Murphy wrote: On 12/21/2018 01:32 AM, Jacek Anaszewski wrote: On 12/20/18 9:31 PM, Jacek Anaszewski wrote: On 12/19/18 10:50 PM, Dan Murphy wrote: On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: Hi Dan and Pavel, On 12/19/18 9:41 PM, Dan Murphy wrote: Pavel On 12/1

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-21 Thread Dan Murphy
On 12/21/2018 01:32 AM, Jacek Anaszewski wrote: > On 12/20/18 9:31 PM, Jacek Anaszewski wrote: >> On 12/19/18 10:50 PM, Dan Murphy wrote: >>> On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: Hi Dan and Pavel, On 12/19/18 9:41 PM, Dan Murphy wrote: > Pavel > > On 12/19/2018

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-20 Thread Jacek Anaszewski
On 12/20/18 9:31 PM, Jacek Anaszewski wrote: On 12/19/18 10:50 PM, Dan Murphy wrote: On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: Hi Dan and Pavel, On 12/19/18 9:41 PM, Dan Murphy wrote: Pavel On 12/19/2018 02:10 PM, Pavel Machek wrote: On Wed 2018-12-19 13:41:18, Dan Murphy wrote: Pave

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-20 Thread Jacek Anaszewski
On 12/19/18 10:50 PM, Dan Murphy wrote: On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: Hi Dan and Pavel, On 12/19/18 9:41 PM, Dan Murphy wrote: Pavel On 12/19/2018 02:10 PM, Pavel Machek wrote: On Wed 2018-12-19 13:41:18, Dan Murphy wrote: Pavel Thanks for the review. On 12/19/2018 01:34

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-20 Thread Dan Murphy
On 12/20/2018 03:06 AM, Pavel Machek wrote: > Hi! > >>> Anyway, if your 36 channels can be set independently, I believe you >>> just want them to export as 36 LEDs. >> >> I am not sure that is what the "customers" would want to have to set 36 >> different nodes or even declare those 36 nodes. >>

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-20 Thread Dan Murphy
Vesa On 12/20/2018 06:40 AM, Vesa Jääskeläinen wrote: > Hi All, > > On 19/12/2018 23.50, Dan Murphy wrote: >> On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: >>> Hi Dan and Pavel, >>> Some time ago we had discussion with Vesa Jääskeläinen about possible >>> approaches to RGB LEDs [0]. What seemed

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-20 Thread Vesa Jääskeläinen
Hi All, On 19/12/2018 23.50, Dan Murphy wrote: On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: Hi Dan and Pavel, Some time ago we had discussion with Vesa Jääskeläinen about possible approaches to RGB LEDs [0]. What seemed to be the most suitable variation of the discussed out-of-tree approach

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-20 Thread Pavel Machek
Hi! > > Anyway, if your 36 channels can be set independently, I believe you > > just want them to export as 36 LEDs. > > I am not sure that is what the "customers" would want to have to set 36 > different nodes or even declare those 36 nodes. > That is 36 independent user space to kernel space c

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Dan Murphy
Pavel Thanks for trimming. On 12/19/2018 04:27 PM, Pavel Machek wrote: > Hi! > > [cc list trimmed] > > I don't think a user needs nor would want to have 24 different LED nodes > with 24 different brightness files. > Or with the LP5036 that would have 36 LED nodes. > > Table

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Pavel Machek
Hi! [cc list trimmed] > >>> I don't think a user needs nor would want to have 24 different LED nodes > >>> with 24 different brightness files. > >>> Or with the LP5036 that would have 36 LED nodes. > >>> > >>> Table 1 in the data sheet shows how the outputs map to the control banks > >>> to the

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Dan Murphy
On 12/19/2018 04:03 PM, Pavel Machek wrote: > Hi! > >>> I don't think a user needs nor would want to have 24 different LED nodes >>> with 24 different brightness files. >>> Or with the LP5036 that would have 36 LED nodes. >>> >>> Table 1 in the data sheet shows how the outputs map to the control

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Pavel Machek
Hi! > >I don't think a user needs nor would want to have 24 different LED nodes > >with 24 different brightness files. > >Or with the LP5036 that would have 36 LED nodes. > > > >Table 1 in the data sheet shows how the outputs map to the control banks to > >the LED registers. > > Some time ago w

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Dan Murphy
On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: > Hi Dan and Pavel, > > On 12/19/18 9:41 PM, Dan Murphy wrote: >> Pavel >> >> On 12/19/2018 02:10 PM, Pavel Machek wrote: >>> On Wed 2018-12-19 13:41:18, Dan Murphy wrote: Pavel Thanks for the review. On 12/19/2018 01:34 PM,

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Jacek Anaszewski
Hi Dan and Pavel, On 12/19/18 9:41 PM, Dan Murphy wrote: Pavel On 12/19/2018 02:10 PM, Pavel Machek wrote: On Wed 2018-12-19 13:41:18, Dan Murphy wrote: Pavel Thanks for the review. On 12/19/2018 01:34 PM, Pavel Machek wrote: Hi! +static DEVICE_ATTR_WO(ctrl_bank_a_mix); +static DEVICE_AT

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Dan Murphy
Pavel On 12/19/2018 02:10 PM, Pavel Machek wrote: > On Wed 2018-12-19 13:41:18, Dan Murphy wrote: >> Pavel >> >> Thanks for the review. >> >> On 12/19/2018 01:34 PM, Pavel Machek wrote: >>> Hi! >>> +static DEVICE_ATTR_WO(ctrl_bank_a_mix); +static DEVICE_ATTR_WO(ctrl_bank_b_mix); +st

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Pavel Machek
On Wed 2018-12-19 13:41:18, Dan Murphy wrote: > Pavel > > Thanks for the review. > > On 12/19/2018 01:34 PM, Pavel Machek wrote: > > Hi! > > > >> +static DEVICE_ATTR_WO(ctrl_bank_a_mix); > >> +static DEVICE_ATTR_WO(ctrl_bank_b_mix); > >> +static DEVICE_ATTR_WO(ctrl_bank_c_mix); > >> + > >> +stat

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Dan Murphy
Pavel Thanks for the review. On 12/19/2018 01:34 PM, Pavel Machek wrote: > Hi! > >> +static DEVICE_ATTR_WO(ctrl_bank_a_mix); >> +static DEVICE_ATTR_WO(ctrl_bank_b_mix); >> +static DEVICE_ATTR_WO(ctrl_bank_c_mix); >> + >> +static struct attribute *lp5024_ctrl_bank_attrs[] = { >> +&dev_attr_ct

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Pavel Machek
Hi! > +static DEVICE_ATTR_WO(ctrl_bank_a_mix); > +static DEVICE_ATTR_WO(ctrl_bank_b_mix); > +static DEVICE_ATTR_WO(ctrl_bank_c_mix); > + > +static struct attribute *lp5024_ctrl_bank_attrs[] = { > + &dev_attr_ctrl_bank_a_mix.attr, > + &dev_attr_ctrl_bank_b_mix.attr, > + &dev_attr_ctrl_b

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Dan Murphy
On 12/19/2018 10:26 AM, Dan Murphy wrote: > Introduce the LP5024 and LP5018 RGB LED driver. > The difference in these 2 parts are only in the number of > LED outputs where the LP5024 can control 24 LEDs the LP5018 > can only control 18. > > The device has the ability to group LED output into contr

[PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-19 Thread Dan Murphy
Introduce the LP5024 and LP5018 RGB LED driver. The difference in these 2 parts are only in the number of LED outputs where the LP5024 can control 24 LEDs the LP5018 can only control 18. The device has the ability to group LED output into control banks so that multiple LED banks can be controlled