Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-11 Thread Timur Tabi
On Mon, Mar 8, 2021 at 4:51 AM Marco Elver wrote: > If we do __initconst change we need to manually remove the duplicate > lines because we're asking the compiler to create a large array (and > there's no more auto-dedup). If we do not remove the duplicate lines, > the __initconst-only approach

RE: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-09 Thread David Laight
... > On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote: > > On Mon, 8 Mar 2021 at 18:23, Petr Mladek wrote: > > > > - > > > pr_warn("**\n"); > > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE >

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-08 Thread Andy Shevchenko
On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote: > On Mon, 8 Mar 2021 at 18:23, Petr Mladek wrote: > > - > > pr_warn("**\n"); > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE > > **\n"); > > -

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-08 Thread Marco Elver
On Mon, 8 Mar 2021 at 18:23, Petr Mladek wrote: [...] > > I'm actually concerned about both. Platforms (and boot loaders) may > > have limitations for kernel image size, too. > > Static memory consumption is also more easily measured, so I tend > > to run bloat-o-meter, and dive into anything

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-08 Thread Petr Mladek
On Mon 2021-03-08 13:22:40, Geert Uytterhoeven wrote: > Hi Petr, > > On Mon, Mar 8, 2021 at 11:16 AM Petr Mladek wrote: > > On Fri 2021-03-05 20:42:06, Marco Elver wrote: > > > Move the no_hash_pointers warning string into __initconst section, so > > > that it is discarded after init. Remove

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-08 Thread Geert Uytterhoeven
Hi Petr, On Mon, Mar 8, 2021 at 11:16 AM Petr Mladek wrote: > On Fri 2021-03-05 20:42:06, Marco Elver wrote: > > Move the no_hash_pointers warning string into __initconst section, so > > that it is discarded after init. Remove common start/end characters. > > Also remove repeated lines from the

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-08 Thread Marco Elver
On Mon, 8 Mar 2021 at 11:16, Petr Mladek wrote: > On Fri 2021-03-05 20:42:06, Marco Elver wrote: > > Move the no_hash_pointers warning string into __initconst section, so > > that it is discarded after init. Remove common start/end characters. > > Also remove repeated lines from the array, since

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-08 Thread Andy Shevchenko
On Fri, Mar 05, 2021 at 08:42:06PM +0100, Marco Elver wrote: > Move the no_hash_pointers warning string into __initconst section, so > that it is discarded after init. Remove common start/end characters. > Also remove repeated lines from the array, since the compiler can't > remove duplicate

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-08 Thread Petr Mladek
On Fri 2021-03-05 20:42:06, Marco Elver wrote: > Move the no_hash_pointers warning string into __initconst section, so > that it is discarded after init. Remove common start/end characters. > Also remove repeated lines from the array, since the compiler can't > remove duplicate strings for us

Re: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-06 Thread Timur Tabi
On Fri, Mar 5, 2021 at 1:46 PM Marco Elver wrote: > +static const char no_hash_pointers_warning[8][55] __initconst = { > + "**", > + " NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE ", > + " This system shows unhashed

[PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning

2021-03-05 Thread Marco Elver
Move the no_hash_pointers warning string into __initconst section, so that it is discarded after init. Remove common start/end characters. Also remove repeated lines from the array, since the compiler can't remove duplicate strings for us since the array must appear in __initconst as defined.