Re: [PATCH 2/2] lib kallsyms: parse using io api

2020-05-01 Thread Ian Rogers
On Fri, May 1, 2020 at 8:28 AM Ian Rogers wrote: > > On Fri, May 1, 2020 at 5:23 AM Jiri Olsa wrote: > > > > On Thu, Apr 30, 2020 at 12:35:57PM -0700, Ian Rogers wrote: > > > Perf record will call kallsyms__parse 4 times during startup and process > > > megabytes of data. This changes kallsyms__p

Re: [PATCH 2/2] lib kallsyms: parse using io api

2020-05-01 Thread Ian Rogers
On Fri, May 1, 2020 at 5:23 AM Jiri Olsa wrote: > > On Thu, Apr 30, 2020 at 12:35:57PM -0700, Ian Rogers wrote: > > Perf record will call kallsyms__parse 4 times during startup and process > > megabytes of data. This changes kallsyms__parse to use the io library > > rather than fgets to improve pe

Re: [PATCH 2/2] lib kallsyms: parse using io api

2020-05-01 Thread Jiri Olsa
On Thu, Apr 30, 2020 at 12:35:57PM -0700, Ian Rogers wrote: > Perf record will call kallsyms__parse 4 times during startup and process > megabytes of data. This changes kallsyms__parse to use the io library > rather than fgets to improve performance of the user code by over 8%. > > Before: > Run

[PATCH 2/2] lib kallsyms: parse using io api

2020-04-30 Thread Ian Rogers
Perf record will call kallsyms__parse 4 times during startup and process megabytes of data. This changes kallsyms__parse to use the io library rather than fgets to improve performance of the user code by over 8%. Before: Running 'internals/kallsyms-parse' benchmark: Average kallsyms__parse too