Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-26 Thread Tang Chen
On 08/24/2015 07:24 PM, Xishi Qiu wrote: .. [ 2007.584000] On node 5 totalpages: 0 [ 2007.585000] Built 5 zonelists in Node order, mobility grouping on. Total pages: 32588823 [ 2007.594000] Policy zone: Normal [ 2007.598000] init_memory_mapping: [mem 0x600-0x607] And

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-26 Thread Tang Chen
On 08/24/2015 07:24 PM, Xishi Qiu wrote: .. [ 2007.584000] On node 5 totalpages: 0 [ 2007.585000] Built 5 zonelists in Node order, mobility grouping on. Total pages: 32588823 [ 2007.594000] Policy zone: Normal [ 2007.598000] init_memory_mapping: [mem 0x600-0x607] And

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-24 Thread Xishi Qiu
On 2015/8/24 17:39, Tang Chen wrote: > > On 08/24/2015 05:17 PM, Xishi Qiu wrote: >> On 2015/8/23 18:28, Tang Chen wrote: >> >>> Hi Shi, >>> >>> Sorry for the late reply. I hope it won't be too late. >>> >>> NON-ACK by me, I think. >>> >>> I noticed that your first has been merged. But it won't

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-24 Thread Tang Chen
On 08/24/2015 05:17 PM, Xishi Qiu wrote: On 2015/8/23 18:28, Tang Chen wrote: Hi Shi, Sorry for the late reply. I hope it won't be too late. NON-ACK by me, I think. I noticed that your first has been merged. But it won't fix the problem these code intended to fix. After your patch 1,

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-24 Thread Xishi Qiu
On 2015/8/23 18:28, Tang Chen wrote: > Hi Shi, > > Sorry for the late reply. I hope it won't be too late. > > NON-ACK by me, I think. > > I noticed that your first has been merged. But it won't fix the problem > these code intended to fix. > > After your patch 1, zone's spanned/present won't

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-24 Thread Tang Chen
On 08/24/2015 05:17 PM, Xishi Qiu wrote: On 2015/8/23 18:28, Tang Chen wrote: Hi Shi, Sorry for the late reply. I hope it won't be too late. NON-ACK by me, I think. I noticed that your first has been merged. But it won't fix the problem these code intended to fix. After your patch 1,

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-24 Thread Xishi Qiu
On 2015/8/23 18:28, Tang Chen wrote: Hi Shi, Sorry for the late reply. I hope it won't be too late. NON-ACK by me, I think. I noticed that your first has been merged. But it won't fix the problem these code intended to fix. After your patch 1, zone's spanned/present won't be set to

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-24 Thread Xishi Qiu
On 2015/8/24 17:39, Tang Chen wrote: On 08/24/2015 05:17 PM, Xishi Qiu wrote: On 2015/8/23 18:28, Tang Chen wrote: Hi Shi, Sorry for the late reply. I hope it won't be too late. NON-ACK by me, I think. I noticed that your first has been merged. But it won't fix the problem these code

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-23 Thread Tang Chen
Hi Shi, Sorry for the late reply. I hope it won't be too late. NON-ACK by me, I think. I noticed that your first has been merged. But it won't fix the problem these code intended to fix. After your patch 1, zone's spanned/present won't be set to 0 because: free_area_init_node() |-->

Re: [PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-23 Thread Tang Chen
Hi Shi, Sorry for the late reply. I hope it won't be too late. NON-ACK by me, I think. I noticed that your first has been merged. But it won't fix the problem these code intended to fix. After your patch 1, zone's spanned/present won't be set to 0 because: free_area_init_node() |--

[PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-11 Thread Xishi Qiu
After hotadd_new_pgdat()->free_area_init_node(), the pgdat and zone's spanned/present are both 0, so remove reset_node_managed_pages() and reset_node_managed_pages(). Signed-off-by: Xishi Qiu --- mm/memory_hotplug.c | 25 - 1 file changed, 25 deletions(-) diff --git

[PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-08-11 Thread Xishi Qiu
After hotadd_new_pgdat()-free_area_init_node(), the pgdat and zone's spanned/present are both 0, so remove reset_node_managed_pages() and reset_node_managed_pages(). Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/memory_hotplug.c | 25 - 1 file changed, 25

[PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-04-17 Thread Xishi Qiu
After hotadd_new_pgdat()->free_area_init_node(), pgdat's spanned/present are 0, and zone's spanned/present/managed are 0, so remove reset_node_managed_pages() and reset_node_managed_pages(). Signed-off-by: Xishi Qiu --- mm/memory_hotplug.c | 25 - 1 files changed, 0

[PATCH 2/2] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()

2015-04-17 Thread Xishi Qiu
After hotadd_new_pgdat()-free_area_init_node(), pgdat's spanned/present are 0, and zone's spanned/present/managed are 0, so remove reset_node_managed_pages() and reset_node_managed_pages(). Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/memory_hotplug.c | 25 - 1