Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Michal Hocko
On Wed 05-09-18 13:18:24, Alexander Duyck wrote: > On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: > > > > On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > It doesn't make much sense to use the atomic SetPageReserved at init time > > > when we are

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Michal Hocko
On Wed 05-09-18 13:18:24, Alexander Duyck wrote: > On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: > > > > On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > It doesn't make much sense to use the atomic SetPageReserved at init time > > > when we are

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Alexander Duyck
On Wed, Sep 5, 2018 at 1:22 PM Pasha Tatashin wrote: > > > > On 9/5/18 4:18 PM, Alexander Duyck wrote: > > On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: > >> > >> On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > >>> From: Alexander Duyck > >>> > >>> It doesn't make much sense to use the

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Alexander Duyck
On Wed, Sep 5, 2018 at 1:22 PM Pasha Tatashin wrote: > > > > On 9/5/18 4:18 PM, Alexander Duyck wrote: > > On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: > >> > >> On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > >>> From: Alexander Duyck > >>> > >>> It doesn't make much sense to use the

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Pasha Tatashin
On 9/5/18 4:18 PM, Alexander Duyck wrote: > On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: >> >> On Tue 04-09-18 11:33:45, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> It doesn't make much sense to use the atomic SetPageReserved at init time >>> when we are using memset to

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Pasha Tatashin
On 9/5/18 4:18 PM, Alexander Duyck wrote: > On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: >> >> On Tue 04-09-18 11:33:45, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> It doesn't make much sense to use the atomic SetPageReserved at init time >>> when we are using memset to

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Alexander Duyck
On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: > > On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > > From: Alexander Duyck > > > > It doesn't make much sense to use the atomic SetPageReserved at init time > > when we are using memset to clear the memory and manipulating the page > >

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Alexander Duyck
On Tue, Sep 4, 2018 at 11:24 PM Michal Hocko wrote: > > On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > > From: Alexander Duyck > > > > It doesn't make much sense to use the atomic SetPageReserved at init time > > when we are using memset to clear the memory and manipulating the page > >

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Michal Hocko
On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > From: Alexander Duyck > > It doesn't make much sense to use the atomic SetPageReserved at init time > when we are using memset to clear the memory and manipulating the page > flags via simple "&=" and "|=" operations in __init_single_page. > >

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-05 Thread Michal Hocko
On Tue 04-09-18 11:33:45, Alexander Duyck wrote: > From: Alexander Duyck > > It doesn't make much sense to use the atomic SetPageReserved at init time > when we are using memset to clear the memory and manipulating the page > flags via simple "&=" and "|=" operations in __init_single_page. > >

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-04 Thread Dave Hansen
On 09/04/2018 11:33 AM, Alexander Duyck wrote: > +++ b/mm/page_alloc.c > @@ -1231,7 +1231,7 @@ void __meminit reserve_bootmem_region(phys_addr_t > start, phys_addr_t end) > /* Avoid false-positive PageTail() */ > INIT_LIST_HEAD(>lru); > > -

Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-04 Thread Dave Hansen
On 09/04/2018 11:33 AM, Alexander Duyck wrote: > +++ b/mm/page_alloc.c > @@ -1231,7 +1231,7 @@ void __meminit reserve_bootmem_region(phys_addr_t > start, phys_addr_t end) > /* Avoid false-positive PageTail() */ > INIT_LIST_HEAD(>lru); > > -

[PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-04 Thread Alexander Duyck
From: Alexander Duyck It doesn't make much sense to use the atomic SetPageReserved at init time when we are using memset to clear the memory and manipulating the page flags via simple "&=" and "|=" operations in __init_single_page. This patch adds a non-atomic version __SetPageReserved that can

[PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use

2018-09-04 Thread Alexander Duyck
From: Alexander Duyck It doesn't make much sense to use the atomic SetPageReserved at init time when we are using memset to clear the memory and manipulating the page flags via simple "&=" and "|=" operations in __init_single_page. This patch adds a non-atomic version __SetPageReserved that can