Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h

2020-11-25 Thread Matthew Wilcox
On Wed, Nov 25, 2020 at 01:34:04PM +0100, Vlastimil Babka wrote: > On 11/25/20 4:46 AM, Matthew Wilcox (Oracle) wrote: > > Code outside mm/ should not be calling free_unref_page(). Also > > move free_unref_page_list(). > > Good idea. > > > Signed-off-by: Matthew Wilcox (Oracle) > > Acked-by:

Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h

2020-11-25 Thread Vlastimil Babka
On 11/25/20 4:46 AM, Matthew Wilcox (Oracle) wrote: Code outside mm/ should not be calling free_unref_page(). Also move free_unref_page_list(). Good idea. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Vlastimil Babka There seems to be some effort to remove "extern" from function

Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h

2020-11-25 Thread Mike Rapoport
On Wed, Nov 25, 2020 at 03:46:55AM +, Matthew Wilcox (Oracle) wrote: > Code outside mm/ should not be calling free_unref_page(). Also > move free_unref_page_list(). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Mike Rapoport > --- > include/linux/gfp.h | 2 -- > mm/internal.h

Re: [PATCH 2/2] mm: Move free_unref_page to mm/internal.h

2020-11-25 Thread David Hildenbrand
On 25.11.20 04:46, Matthew Wilcox (Oracle) wrote: > Code outside mm/ should not be calling free_unref_page(). Also > move free_unref_page_list(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/gfp.h | 2 -- > mm/internal.h | 3 +++ > 2 files changed, 3 insertions(+), 2

[PATCH 2/2] mm: Move free_unref_page to mm/internal.h

2020-11-24 Thread Matthew Wilcox (Oracle)
Code outside mm/ should not be calling free_unref_page(). Also move free_unref_page_list(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/gfp.h | 2 -- mm/internal.h | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/linux/gfp.h