Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-16 Thread Sonny Rao
On Tue, Jan 15, 2013 at 8:47 PM, Minchan Kim wrote: > On Tue, Jan 15, 2013 at 05:21:15PM -0800, Sonny Rao wrote: >> On Tue, Jan 15, 2013 at 4:50 PM, Andrew Morton >> wrote: >> > On Tue, 15 Jan 2013 16:32:38 -0800 >> > Sonny Rao wrote: >> > >> >> >> It's for saving the power to increase batter li

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-15 Thread Minchan Kim
On Tue, Jan 15, 2013 at 05:21:15PM -0800, Sonny Rao wrote: > On Tue, Jan 15, 2013 at 4:50 PM, Andrew Morton > wrote: > > On Tue, 15 Jan 2013 16:32:38 -0800 > > Sonny Rao wrote: > > > >> >> It's for saving the power to increase batter life. > >> > > >> > It might well have that effect, dunno. Tha

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-15 Thread Minchan Kim
On Tue, Jan 15, 2013 at 04:09:57PM -0800, Andrew Morton wrote: > On Fri, 11 Jan 2013 13:43:27 +0900 > Minchan Kim wrote: > > > Hi Andrew, > > > > On Thu, Jan 10, 2013 at 01:58:28PM -0800, Andrew Morton wrote: > > > On Thu, 10 Jan 2013 11:23:06 +0900 > > > Minchan Kim wrote: > > > > > > > > I h

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-15 Thread Sonny Rao
On Tue, Jan 15, 2013 at 4:50 PM, Andrew Morton wrote: > On Tue, 15 Jan 2013 16:32:38 -0800 > Sonny Rao wrote: > >> >> It's for saving the power to increase batter life. >> > >> > It might well have that effect, dunno. That wasn't my intent. Testing >> > needed! >> > >> >> Power saving is certai

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-15 Thread Andrew Morton
On Tue, 15 Jan 2013 16:32:38 -0800 Sonny Rao wrote: > >> It's for saving the power to increase batter life. > > > > It might well have that effect, dunno. That wasn't my intent. Testing > > needed! > > > > Power saving is certainly why we had it on originally for ChromeOS, > but we turned it o

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-15 Thread Sonny Rao
On Tue, Jan 15, 2013 at 4:09 PM, Andrew Morton wrote: > On Fri, 11 Jan 2013 13:43:27 +0900 > Minchan Kim wrote: > >> Hi Andrew, >> >> On Thu, Jan 10, 2013 at 01:58:28PM -0800, Andrew Morton wrote: >> > On Thu, 10 Jan 2013 11:23:06 +0900 >> > Minchan Kim wrote: >> > >> > > > I have a feeling that

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-15 Thread Andrew Morton
On Fri, 11 Jan 2013 13:43:27 +0900 Minchan Kim wrote: > Hi Andrew, > > On Thu, Jan 10, 2013 at 01:58:28PM -0800, Andrew Morton wrote: > > On Thu, 10 Jan 2013 11:23:06 +0900 > > Minchan Kim wrote: > > > > > > I have a feeling that laptop mode has bitrotted and these patches are > > > > kinda ha

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-10 Thread Minchan Kim
Hi Andrew, On Thu, Jan 10, 2013 at 01:58:28PM -0800, Andrew Morton wrote: > On Thu, 10 Jan 2013 11:23:06 +0900 > Minchan Kim wrote: > > > > I have a feeling that laptop mode has bitrotted and these patches are > > > kinda hacking around as-yet-not-understood failures... > > > > Absolutely, this

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-10 Thread Andrew Morton
On Thu, 10 Jan 2013 11:23:06 +0900 Minchan Kim wrote: > > I have a feeling that laptop mode has bitrotted and these patches are > > kinda hacking around as-yet-not-understood failures... > > Absolutely, this patch is last guard for unexpectable behavior. > As I mentioned in cover-letter, Luigi's

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-09 Thread Minchan Kim
On Wed, Jan 09, 2013 at 04:26:02PM -0800, Andrew Morton wrote: > On Wed, 9 Jan 2013 15:21:14 +0900 > Minchan Kim wrote: > > > If laptop_mode is enable, VM try to avoid I/O for saving the power. > > But if there isn't reclaimable memory without I/O, we should do I/O > > for preventing unnecessary

Re: [PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-09 Thread Andrew Morton
On Wed, 9 Jan 2013 15:21:14 +0900 Minchan Kim wrote: > If laptop_mode is enable, VM try to avoid I/O for saving the power. > But if there isn't reclaimable memory without I/O, we should do I/O > for preventing unnecessary OOM kill although we sacrifices power. > > One of example is that we are

[PATCH 2/2] mm: forcely swapout when we are out of page cache

2013-01-08 Thread Minchan Kim
If laptop_mode is enable, VM try to avoid I/O for saving the power. But if there isn't reclaimable memory without I/O, we should do I/O for preventing unnecessary OOM kill although we sacrifices power. One of example is that we are out of page cache. Remained one is only anonymous pages, for swapp