Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-21 Thread Michael Ellerman
Andrew Morton writes: > On Thu, 21 Dec 2017 23:38:37 +1100 Michael Ellerman > wrote: > >> > Andrew, can you s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g in the series? > > Done. Thanks. I sent an ack at some point, here's another if you like: Acked-by: Michael Ellerman There's also a couple of

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-21 Thread Andrew Morton
On Thu, 21 Dec 2017 23:38:37 +1100 Michael Ellerman wrote: > > Andrew, can you s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g in the series? Done.

Re: known bad patch in -mm tree was Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-21 Thread Michal Hocko
On Thu 21-12-17 15:59:07, Pavel Machek wrote: > Hi! > > > >>> And if Michal doesn't want to touch this patch any more, I'm happy to > > >>> do the search/replace/resend. :P > > >> > > >> Something with the prefix MAP_FIXED_ seems to me obviously desirable, > > >> both to suggest that the function

known bad patch in -mm tree was Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-21 Thread Pavel Machek
Hi! > >>> And if Michal doesn't want to touch this patch any more, I'm happy to > >>> do the search/replace/resend. :P > >> > >> Something with the prefix MAP_FIXED_ seems to me obviously desirable, > >> both to suggest that the function is similar, and also for easy > >> grepping of the source co

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-21 Thread Michael Ellerman
Kees Cook writes: > On Mon, Dec 18, 2017 at 11:12 AM, Michael Kerrisk (man-pages) > wrote: >> Hello Kees, >> >> I'm late to the party, and only just caught up with the fuss :-). > > No worries! > >> On 12/14/2017 12:19 AM, Kees Cook wrote: >>> On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-18 Thread Matthew Wilcox
On Mon, Dec 18, 2017 at 12:19:21PM -0800, Kees Cook wrote: > Andrew, can you s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g in the series? +1

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-18 Thread Kees Cook
On Mon, Dec 18, 2017 at 11:12 AM, Michael Kerrisk (man-pages) wrote: > Hello Kees, > > I'm late to the party, and only just caught up with the fuss :-). No worries! > On 12/14/2017 12:19 AM, Kees Cook wrote: >> On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: >>> Hi! You selected stupi

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-18 Thread Michael Kerrisk (man-pages)
Hello Kees, I'm late to the party, and only just caught up with the fuss :-). On 12/14/2017 12:19 AM, Kees Cook wrote: > On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: >> Hi! >>> You selected stupid name for a flag. Everyone and their dog agrees >>> with that. There's even consensus on bet

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-14 Thread Jann Horn
On Fri, Dec 15, 2017 at 12:06 AM, John Hubbard wrote: > On 12/13/2017 06:52 PM, Jann Horn wrote: >> On Wed, Dec 13, 2017 at 10:31 AM, Michal Hocko wrote: >>> From: John Hubbard > [...] >>> +.IP >>> +Furthermore, this option is extremely hazardous (when used on its own), >>> because >>> +it forc

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-14 Thread John Hubbard
On 12/13/2017 06:52 PM, Jann Horn wrote: > On Wed, Dec 13, 2017 at 10:31 AM, Michal Hocko wrote: >> From: John Hubbard [...] >> +.IP >> +Furthermore, this option is extremely hazardous (when used on its own), >> because >> +it forcibly removes pre-existing mappings, making it easy for a >> mult

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Michal Hocko
On Wed 13-12-17 15:19:00, Kees Cook wrote: > On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: > > Hi! > >> You selected stupid name for a flag. Everyone and their dog agrees > >> with that. There's even consensus on better name (and everyone agrees > >> it is better than .._SAFE). Of course, w

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread John Hubbard
On 12/13/2017 06:52 PM, Jann Horn wrote: > On Wed, Dec 13, 2017 at 10:31 AM, Michal Hocko wrote: >> From: John Hubbard >> >> -- Expand the documentation to discuss the hazards in >>enough detail to allow avoiding them. >> >> -- Mention the upcoming MAP_FIXED_SAFE flag. >> >> -

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Jann Horn
On Wed, Dec 13, 2017 at 10:31 AM, Michal Hocko wrote: > From: John Hubbard > > -- Expand the documentation to discuss the hazards in >enough detail to allow avoiding them. > > -- Mention the upcoming MAP_FIXED_SAFE flag. > > -- Enhance the alignment requirement slightly. > > C

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Kees Cook
On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: > Hi! >> You selected stupid name for a flag. Everyone and their dog agrees >> with that. There's even consensus on better name (and everyone agrees >> it is better than .._SAFE). Of course, we could have debate if it is >> NOREPLACE or NOREMOVE

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Cyril Hrubis
Hi! > You selected stupid name for a flag. Everyone and their dog agrees > with that. There's even consensus on better name (and everyone agrees > it is better than .._SAFE). Of course, we could have debate if it is > NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just > poor nam

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Michal Hocko
On Wed 13-12-17 14:21:05, Pavel Machek wrote: > On Wed 2017-12-13 14:16:40, Michal Hocko wrote: > > On Wed 13-12-17 14:09:00, Pavel Machek wrote: > > > On Wed 2017-12-13 14:04:58, Michal Hocko wrote: > > > > On Wed 13-12-17 13:55:40, Pavel Machek wrote: > > > > > On Wed 2017-12-13 10:31:10, Michal

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Pavel Machek
On Wed 2017-12-13 14:16:40, Michal Hocko wrote: > On Wed 13-12-17 14:09:00, Pavel Machek wrote: > > On Wed 2017-12-13 14:04:58, Michal Hocko wrote: > > > On Wed 13-12-17 13:55:40, Pavel Machek wrote: > > > > On Wed 2017-12-13 10:31:10, Michal Hocko wrote: > > > > > From: John Hubbard > > > > > >

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Michal Hocko
On Wed 13-12-17 14:09:00, Pavel Machek wrote: > On Wed 2017-12-13 14:04:58, Michal Hocko wrote: > > On Wed 13-12-17 13:55:40, Pavel Machek wrote: > > > On Wed 2017-12-13 10:31:10, Michal Hocko wrote: > > > > From: John Hubbard > > > > > > > > -- Expand the documentation to discuss the hazards

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Pavel Machek
On Wed 2017-12-13 14:04:58, Michal Hocko wrote: > On Wed 13-12-17 13:55:40, Pavel Machek wrote: > > On Wed 2017-12-13 10:31:10, Michal Hocko wrote: > > > From: John Hubbard > > > > > > -- Expand the documentation to discuss the hazards in > > >enough detail to allow avoiding them. > >

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Michal Hocko
On Wed 13-12-17 13:55:40, Pavel Machek wrote: > On Wed 2017-12-13 10:31:10, Michal Hocko wrote: > > From: John Hubbard > > > > -- Expand the documentation to discuss the hazards in > >enough detail to allow avoiding them. > > > > -- Mention the upcoming MAP_FIXED_SAFE flag. > >

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Cyril Hrubis
Hi! > Pretty map everyone agreed MAP_FIXED_SAFE was a bad > name. MAP_FIXED_NOREPLACE (IIRC) was best replacement. For what it's worth I do agree here. -- Cyril Hrubis chru...@suse.cz

Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Pavel Machek
On Wed 2017-12-13 10:31:10, Michal Hocko wrote: > From: John Hubbard > > -- Expand the documentation to discuss the hazards in >enough detail to allow avoiding them. > > -- Mention the upcoming MAP_FIXED_SAFE flag. Pretty map everyone agreed MAP_FIXED_SAFE was a bad name. MAP_FI

[PATCH 2/2] mmap.2: MAP_FIXED updated documentation

2017-12-13 Thread Michal Hocko
From: John Hubbard -- Expand the documentation to discuss the hazards in enough detail to allow avoiding them. -- Mention the upcoming MAP_FIXED_SAFE flag. -- Enhance the alignment requirement slightly. CC: Michael Ellerman CC: Jann Horn CC: Matthew Wilcox CC: Michal Hock