Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-05-08 Thread Lee Jones
> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. > >> > >> commit did use > >> mutex_unlock() in tasklet, but mutex_unlock() can't used in > >> tasklet(atomic context). The driver need use mutex to avoid concurrency, > >> so we can't use tasklet here, the patch need to be

Re: [PATCH 2/2] mmc: rtsx: Revert mmc: rtsx: add support for pre_req and post_req

2014-05-08 Thread Lee Jones
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. commit mmc: rtsx: add support for pre_req and post_req did use mutex_unlock() in tasklet, but mutex_unlock() can't used in tasklet(atomic context). The driver need use mutex to avoid concurrency, so we can't use tasklet

Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-05-05 Thread Ulf Hansson
On 29 April 2014 09:36, Ulf Hansson wrote: > On 29 April 2014 03:54, wrote: >> From: Micky Ching >> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. >> >> commit did use >> mutex_unlock() in tasklet, but mutex_unlock() can't used in >> tasklet(atomic context). The driver need

Re: [PATCH 2/2] mmc: rtsx: Revert mmc: rtsx: add support for pre_req and post_req

2014-05-05 Thread Ulf Hansson
On 29 April 2014 09:36, Ulf Hansson ulf.hans...@linaro.org wrote: On 29 April 2014 03:54, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. commit mmc: rtsx: add support for pre_req and post_req did

Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-29 Thread Ulf Hansson
On 29 April 2014 03:54, wrote: > From: Micky Ching > > This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. > > commit did use > mutex_unlock() in tasklet, but mutex_unlock() can't used in > tasklet(atomic context). The driver need use mutex to avoid concurrency, > so we can't use

Re: [PATCH 2/2] mmc: rtsx: Revert mmc: rtsx: add support for pre_req and post_req

2014-04-29 Thread Ulf Hansson
On 29 April 2014 03:54, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. commit mmc: rtsx: add support for pre_req and post_req did use mutex_unlock() in tasklet, but mutex_unlock() can't used in

[PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread micky_ching
From: Micky Ching This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. commit did use mutex_unlock() in tasklet, but mutex_unlock() can't used in tasklet(atomic context). The driver need use mutex to avoid concurrency, so we can't use tasklet here, the patch need to be removed. The

[PATCH 2/2] mmc: rtsx: Revert mmc: rtsx: add support for pre_req and post_req

2014-04-28 Thread micky_ching
From: Micky Ching micky_ch...@realsil.com.cn This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. commit mmc: rtsx: add support for pre_req and post_req did use mutex_unlock() in tasklet, but mutex_unlock() can't used in tasklet(atomic context). The driver need use mutex to avoid