Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-15 Thread Ulf Hansson
On 2 September 2015 at 17:16, Vaibhav Hiremath wrote: > > > On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote: >> >> On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: >>> >>> On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530,

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-15 Thread Ulf Hansson
On 2 September 2015 at 17:16, Vaibhav Hiremath wrote: > > > On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote: >> >> On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: >>> >>> On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote: On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Joe Perches
On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: > On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: > > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > >> Return value would give clear information about the actual root-cause > >> of the failure. > >> diff --git

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c @@ -455,7

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message.

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message.

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Joe Perches
On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: > On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: > > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > >> Return value would give clear information about the actual root-cause > >> of the failure. > >> diff --git

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote: On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c @@ -455,7

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Joe Perches
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > Return value would give clear information about the actual root-cause > of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message. > diff --git a/drivers/mmc/host/sdhci-pxav3.c

[PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Vaibhav Hiremath
Return value would give clear information about the actual root-cause of the failure. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index

[PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Vaibhav Hiremath
Return value would give clear information about the actual root-cause of the failure. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Joe Perches
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > Return value would give clear information about the actual root-cause > of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message. > diff --git a/drivers/mmc/host/sdhci-pxav3.c