Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-20 Thread Boris Brezillon
Hi Philipp, On Mon, 20 Jun 2016 14:05:54 +0200 Philipp Zabel wrote: > Am Sonntag, den 19.06.2016, 14:06 +0200 schrieb Boris Brezillon: > > +Philipp > > > > On Sun, 19 Jun 2016 19:37:39 +0800 > > Icenowy Zheng wrote: > > > > > The NAND controller on

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-20 Thread Boris Brezillon
Hi Philipp, On Mon, 20 Jun 2016 14:05:54 +0200 Philipp Zabel wrote: > Am Sonntag, den 19.06.2016, 14:06 +0200 schrieb Boris Brezillon: > > +Philipp > > > > On Sun, 19 Jun 2016 19:37:39 +0800 > > Icenowy Zheng wrote: > > > > > The NAND controller on some sun8i chips needs its reset line to

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-20 Thread Philipp Zabel
Am Sonntag, den 19.06.2016, 14:06 +0200 schrieb Boris Brezillon: > +Philipp > > On Sun, 19 Jun 2016 19:37:39 +0800 > Icenowy Zheng wrote: > > > The NAND controller on some sun8i chips needs its reset line to be > > deasserted > > before they can enter working state. This

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-20 Thread Philipp Zabel
Am Sonntag, den 19.06.2016, 14:06 +0200 schrieb Boris Brezillon: > +Philipp > > On Sun, 19 Jun 2016 19:37:39 +0800 > Icenowy Zheng wrote: > > > The NAND controller on some sun8i chips needs its reset line to be > > deasserted > > before they can enter working state. This commit added the reset

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
On Sun, 19 Jun 2016 21:11:00 +0800 icen...@aosc.xyz wrote: > Then I will soon make the v2 patch set, with the error detection part fixed. > > But why does sunxi-mmc check only EPROBE_DEFER? I guess someone had a probe-dependency problem and fixed this case but ignored all the possible errors.

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
On Sun, 19 Jun 2016 21:11:00 +0800 icen...@aosc.xyz wrote: > Then I will soon make the v2 patch set, with the error detection part fixed. > > But why does sunxi-mmc check only EPROBE_DEFER? I guess someone had a probe-dependency problem and fixed this case but ignored all the possible errors.

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
On Sun, 19 Jun 2016 20:41:09 +0800 icen...@aosc.xyz wrote: > To be honest, I copied them from sunxi-mmc.c. > > What function should be chosen better? You did the right thing (except for the error detection part). My question was addressed to Philipp (the reset subsystem maintainer). > > >

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
On Sun, 19 Jun 2016 20:41:09 +0800 icen...@aosc.xyz wrote: > To be honest, I copied them from sunxi-mmc.c. > > What function should be chosen better? You did the right thing (except for the error detection part). My question was addressed to Philipp (the reset subsystem maintainer). > > >

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
+Philipp On Sun, 19 Jun 2016 19:37:39 +0800 Icenowy Zheng wrote: > The NAND controller on some sun8i chips needs its reset line to be deasserted > before they can enter working state. This commit added the reset line process > to the driver. > > Signed-off-by: Icenowy Zheng

Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
+Philipp On Sun, 19 Jun 2016 19:37:39 +0800 Icenowy Zheng wrote: > The NAND controller on some sun8i chips needs its reset line to be deasserted > before they can enter working state. This commit added the reset line process > to the driver. > > Signed-off-by: Icenowy Zheng > --- >