Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Yixun Lan
HI Boris On 07/19/18 16:39, Boris Brezillon wrote: > Hi Yixun, > > On Thu, 19 Jul 2018 16:13:47 +0800 > Yixun Lan wrote: > > You're doing DMA on those buffers, and devm_kzalloc() is not > DMA-friendly (returned buffers are not aligned on a cache line). Also, > you don't have to

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Yixun Lan
HI Boris On 07/19/18 16:39, Boris Brezillon wrote: > Hi Yixun, > > On Thu, 19 Jul 2018 16:13:47 +0800 > Yixun Lan wrote: > > You're doing DMA on those buffers, and devm_kzalloc() is not > DMA-friendly (returned buffers are not aligned on a cache line). Also, > you don't have to

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Boris Brezillon
Hi Yixun, On Thu, 19 Jul 2018 16:13:47 +0800 Yixun Lan wrote: > >>> You're doing DMA on those buffers, and devm_kzalloc() is not > >>> DMA-friendly (returned buffers are not aligned on a cache line). Also, > >>> you don't have to allocate your own buffers because the core already > >>> allocate

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Boris Brezillon
Hi Yixun, On Thu, 19 Jul 2018 16:13:47 +0800 Yixun Lan wrote: > >>> You're doing DMA on those buffers, and devm_kzalloc() is not > >>> DMA-friendly (returned buffers are not aligned on a cache line). Also, > >>> you don't have to allocate your own buffers because the core already > >>> allocate

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Yixun Lan
HI Boris: thanks for the quick response. On 07/19/18 03:08, Boris Brezillon wrote: > Hi Yixun, > > On Wed, 18 Jul 2018 17:38:56 +0800 > Yixun Lan wrote: > + +#define NFC_REG_CMD 0x00 +#define NFC_REG_CFG 0x04 +#define NFC_REG_DADR

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Yixun Lan
HI Boris: thanks for the quick response. On 07/19/18 03:08, Boris Brezillon wrote: > Hi Yixun, > > On Wed, 18 Jul 2018 17:38:56 +0800 > Yixun Lan wrote: > + +#define NFC_REG_CMD 0x00 +#define NFC_REG_CFG 0x04 +#define NFC_REG_DADR

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-18 Thread Boris Brezillon
Hi Yixun, On Wed, 18 Jul 2018 17:38:56 +0800 Yixun Lan wrote: > >> + > >> +#define NFC_REG_CMD 0x00 > >> +#define NFC_REG_CFG 0x04 > >> +#define NFC_REG_DADR 0x08 > >> +#define NFC_REG_IADR 0x0c > >> +#define NFC_REG_BUF 0x10 >

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-18 Thread Boris Brezillon
Hi Yixun, On Wed, 18 Jul 2018 17:38:56 +0800 Yixun Lan wrote: > >> + > >> +#define NFC_REG_CMD 0x00 > >> +#define NFC_REG_CFG 0x04 > >> +#define NFC_REG_DADR 0x08 > >> +#define NFC_REG_IADR 0x0c > >> +#define NFC_REG_BUF 0x10 >

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-18 Thread Yixun Lan
Hi Roris thanks for all your suggestions! It actually takes us some time to digest all your comments ;-) and get back to you on these questions. On 06/25/18 03:38, Boris Brezillon wrote: > > > Hi Yixun, > > On Wed, 13 Jun 2018 16:13:14 + > Yixun Lan wrote: > >> From: Liang Yang >> >>

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-18 Thread Yixun Lan
Hi Roris thanks for all your suggestions! It actually takes us some time to digest all your comments ;-) and get back to you on these questions. On 06/25/18 03:38, Boris Brezillon wrote: > > > Hi Yixun, > > On Wed, 13 Jun 2018 16:13:14 + > Yixun Lan wrote: > >> From: Liang Yang >> >>

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-02 Thread Yixun Lan
HI Kevin On 06/29/18 07:45, Kevin Hilman wrote: > Hi Miquel, > > Miquel Raynal writes: > >> On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman >> wrote: >> >>> Hi Boris, >>> >>> Boris Brezillon writes: >>> Hi Yixun, On Wed, 13 Jun 2018 16:13:14 + Yixun Lan wrote:

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-02 Thread Yixun Lan
HI Kevin On 06/29/18 07:45, Kevin Hilman wrote: > Hi Miquel, > > Miquel Raynal writes: > >> On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman >> wrote: >> >>> Hi Boris, >>> >>> Boris Brezillon writes: >>> Hi Yixun, On Wed, 13 Jun 2018 16:13:14 + Yixun Lan wrote:

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-29 Thread Neil Armstrong
On 29/06/2018 01:45, Kevin Hilman wrote: > Hi Miquel, > > Miquel Raynal writes: > >> On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman >> wrote: >> >>> Hi Boris, >>> >>> Boris Brezillon writes: >>> Hi Yixun, On Wed, 13 Jun 2018 16:13:14 + Yixun Lan wrote: >

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-29 Thread Neil Armstrong
On 29/06/2018 01:45, Kevin Hilman wrote: > Hi Miquel, > > Miquel Raynal writes: > >> On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman >> wrote: >> >>> Hi Boris, >>> >>> Boris Brezillon writes: >>> Hi Yixun, On Wed, 13 Jun 2018 16:13:14 + Yixun Lan wrote: >

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-28 Thread Kevin Hilman
Hi Miquel, Miquel Raynal writes: > On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman > wrote: > >> Hi Boris, >> >> Boris Brezillon writes: >> >> > Hi Yixun, >> > >> > On Wed, 13 Jun 2018 16:13:14 + >> > Yixun Lan wrote: >> > >> >> From: Liang Yang >> >> >> >> Add initial support for

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-28 Thread Kevin Hilman
Hi Miquel, Miquel Raynal writes: > On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman > wrote: > >> Hi Boris, >> >> Boris Brezillon writes: >> >> > Hi Yixun, >> > >> > On Wed, 13 Jun 2018 16:13:14 + >> > Yixun Lan wrote: >> > >> >> From: Liang Yang >> >> >> >> Add initial support for

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-28 Thread Miquel Raynal
Hi Kevin, On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman wrote: > Hi Boris, > > Boris Brezillon writes: > > > Hi Yixun, > > > > On Wed, 13 Jun 2018 16:13:14 + > > Yixun Lan wrote: > > > >> From: Liang Yang > >> > >> Add initial support for the Amlogic NAND flash controller which

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-28 Thread Miquel Raynal
Hi Kevin, On Wed, 27 Jun 2018 16:33:43 -0700, Kevin Hilman wrote: > Hi Boris, > > Boris Brezillon writes: > > > Hi Yixun, > > > > On Wed, 13 Jun 2018 16:13:14 + > > Yixun Lan wrote: > > > >> From: Liang Yang > >> > >> Add initial support for the Amlogic NAND flash controller which

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-27 Thread Kevin Hilman
Hi Boris, Boris Brezillon writes: > Hi Yixun, > > On Wed, 13 Jun 2018 16:13:14 + > Yixun Lan wrote: > >> From: Liang Yang >> >> Add initial support for the Amlogic NAND flash controller which found >> in the Meson-GXBB/GXL/AXG SoCs. >> >> Singed-off-by: Liang Yang >> Signed-off-by:

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-27 Thread Kevin Hilman
Hi Boris, Boris Brezillon writes: > Hi Yixun, > > On Wed, 13 Jun 2018 16:13:14 + > Yixun Lan wrote: > >> From: Liang Yang >> >> Add initial support for the Amlogic NAND flash controller which found >> in the Meson-GXBB/GXL/AXG SoCs. >> >> Singed-off-by: Liang Yang >> Signed-off-by:

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-24 Thread Boris Brezillon
Hi Yixun, On Wed, 13 Jun 2018 16:13:14 + Yixun Lan wrote: > From: Liang Yang > > Add initial support for the Amlogic NAND flash controller which found > in the Meson-GXBB/GXL/AXG SoCs. > > Singed-off-by: Liang Yang > Signed-off-by: Yixun Lan > --- > drivers/mtd/nand/raw/Kconfig

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-24 Thread Boris Brezillon
Hi Yixun, On Wed, 13 Jun 2018 16:13:14 + Yixun Lan wrote: > From: Liang Yang > > Add initial support for the Amlogic NAND flash controller which found > in the Meson-GXBB/GXL/AXG SoCs. > > Singed-off-by: Liang Yang > Signed-off-by: Yixun Lan > --- > drivers/mtd/nand/raw/Kconfig

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-13 Thread kbuild test robot
Hi Liang, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/nand/next] [also build test ERROR on v4.17 next-20180613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-13 Thread kbuild test robot
Hi Liang, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/nand/next] [also build test ERROR on v4.17 next-20180613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-13 Thread kbuild test robot
Hi Liang, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/nand/next] [also build test ERROR on v4.17 next-20180613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-13 Thread kbuild test robot
Hi Liang, Thank you for the patch! Yet something to improve: [auto build test ERROR on mtd/nand/next] [also build test ERROR on v4.17 next-20180613] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-13 Thread Yixun Lan
From: Liang Yang Add initial support for the Amlogic NAND flash controller which found in the Meson-GXBB/GXL/AXG SoCs. Singed-off-by: Liang Yang Signed-off-by: Yixun Lan --- drivers/mtd/nand/raw/Kconfig |8 + drivers/mtd/nand/raw/Makefile |3 +

[PATCH 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-06-13 Thread Yixun Lan
From: Liang Yang Add initial support for the Amlogic NAND flash controller which found in the Meson-GXBB/GXL/AXG SoCs. Singed-off-by: Liang Yang Signed-off-by: Yixun Lan --- drivers/mtd/nand/raw/Kconfig |8 + drivers/mtd/nand/raw/Makefile |3 +