Re: [PATCH 2/2] mtip32xx: Unmap the DMA segments before completing the IO request

2014-03-13 Thread Jens Axboe
On 03/13/2014 08:34 AM, Felipe Franciosi wrote: If the buffers are unmapped after completing a request, then stale data might be in the request. Both should be marked for stable, I'll add that. Sam, I'll queue these two up. Please re-send your fix for bug introduced with the unaligned reducti

[PATCH 2/2] mtip32xx: Unmap the DMA segments before completing the IO request

2014-03-13 Thread Felipe Franciosi
If the buffers are unmapped after completing a request, then stale data might be in the request. Signed-off-by: Felipe Franciosi --- drivers/block/mtip32xx/mtip32xx.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.

Re: [PATCH 2/2] mtip32xx: Unmap the DMA segments before completing the IO request

2014-03-12 Thread Sam Bradshaw
On 03/12/2014 09:05 AM, Felipe Franciosi wrote: If the buffers are unmapped after completing a request, then stale data might be in the request. Good find, Felipe, thank you. I would prefer something along the lines of this patch to make sure to avoid double completions / dma_unmap_sg() call

Re: [PATCH 2/2] mtip32xx: Unmap the DMA segments before completing the IO request

2014-03-12 Thread Jens Axboe
On 03/12/2014 10:05 AM, Felipe Franciosi wrote: If the buffers are unmapped after completing a request, then stale data might be in the request. This is unfortunate, and a real bug. Good catch! -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

[PATCH 2/2] mtip32xx: Unmap the DMA segments before completing the IO request

2014-03-12 Thread Felipe Franciosi
If the buffers are unmapped after completing a request, then stale data might be in the request. Signed-off-by: Felipe Franciosi --- drivers/block/mtip32xx/mtip32xx.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.