Re: [PATCH 2/2] net/core: some functions' definition order adjustment for readability

2007-07-18 Thread rae l
On 7/18/07, Patrick McHardy <[EMAIL PROTECTED]> wrote: This could be done in the patch moving it .. anyways, What? Denis Cheng wrote: > +#ifdef CONFIG_PROC_FS > +static void *dev_mc_seq_start(struct seq_file *seq, loff_t *pos) If you're interested in doing more work, it would be nice to ge

Re: [PATCH 2/2] net/core: some functions' definition order adjustment for readability

2007-07-18 Thread Patrick McHardy
This could be done in the patch moving it .. anyways, Denis Cheng wrote: > +#ifdef CONFIG_PROC_FS > +static void *dev_mc_seq_start(struct seq_file *seq, loff_t *pos) If you're interested in doing more work, it would be nice to generalize the seq-file functions for unicast and multicast address

[PATCH 2/2] net/core: some functions' definition order adjustment for readability

2007-07-18 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- net/core/dev.c | 407 1 files changed, 201 insertions(+), 206 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 16842af..ee567dd 100644 --- a/net/core/dev.c +++ b/net/core/de