Re: [PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-14 Thread David Miller
From: Nicolas Ferre Date: Wed, 14 Jan 2015 16:53:25 +0100 > I see some issues with this patch: can you hold it a little bit please > (aka NAK)? I already applied these patches last night to my net-next tree, so relative fixups against that will need to be submitted. Submitting new versions of

Re: [PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-14 Thread Nicolas Ferre
Le 13/01/2015 23:15, Xander Huff a écrit : > Currently `ethtool -S` simply returns "no stats available". It > would be more useful to see what the various ethtool statistics > registers' values are. This change implements get_ethtool_stats, > get_strings, and get_sset_count functions to accomplish

Re: [PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-14 Thread David Miller
From: Nicolas Ferre nicolas.fe...@atmel.com Date: Wed, 14 Jan 2015 16:53:25 +0100 I see some issues with this patch: can you hold it a little bit please (aka NAK)? I already applied these patches last night to my net-next tree, so relative fixups against that will need to be submitted.

Re: [PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-14 Thread Nicolas Ferre
Le 13/01/2015 23:15, Xander Huff a écrit : Currently `ethtool -S` simply returns no stats available. It would be more useful to see what the various ethtool statistics registers' values are. This change implements get_ethtool_stats, get_strings, and get_sset_count functions to accomplish this.

Re: [PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-13 Thread David Miller
From: Xander Huff Date: Tue, 13 Jan 2015 16:15:51 -0600 > Currently `ethtool -S` simply returns "no stats available". It > would be more useful to see what the various ethtool statistics > registers' values are. This change implements get_ethtool_stats, > get_strings, and get_sset_count

[PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-13 Thread Xander Huff
Currently `ethtool -S` simply returns "no stats available". It would be more useful to see what the various ethtool statistics registers' values are. This change implements get_ethtool_stats, get_strings, and get_sset_count functions to accomplish this. Read all GEM statistics registers and sum

Re: [PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-13 Thread David Miller
From: Xander Huff xander.h...@ni.com Date: Tue, 13 Jan 2015 16:15:51 -0600 Currently `ethtool -S` simply returns no stats available. It would be more useful to see what the various ethtool statistics registers' values are. This change implements get_ethtool_stats, get_strings, and

[PATCH 2/2] net/macb: improved ethtool statistics support

2015-01-13 Thread Xander Huff
Currently `ethtool -S` simply returns no stats available. It would be more useful to see what the various ethtool statistics registers' values are. This change implements get_ethtool_stats, get_strings, and get_sset_count functions to accomplish this. Read all GEM statistics registers and sum