Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-19 Thread Dan Carpenter
Hi Jonathan, url: https://github.com/0day-ci/linux/commits/Jonathan-McDowell/net-dsa-qca8k-Add-SGMII-configuration-options/20200606-021254 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: i386-randconfig-m021-20200618 (attached as .config) compiler:

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 02:43:56PM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > > So the device in question is a 7 port stand alone switch chip. There's a > > single SGMII port which is configurable between port 0 + 6 (they can

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Andrew Lunn
> > > > Also, netdev is closed at the moment, so please post patches as RFC. > > > > > > "closed"? If you mean this won't get into 5.8 then I wasn't expecting it > > > to, I'm aware the merge window for that is already open. > > > > See

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Russell King - ARM Linux admin
On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > So the device in question is a 7 port stand alone switch chip. There's a > single SGMII port which is configurable between port 0 + 6 (they can > also be configure up as RGMII, while the remaining 5 ports have their > own phys).

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 09:37:41AM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jun 06, 2020 at 08:49:16AM +0100, Jonathan McDowell wrote: > > On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > > > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > > > The

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Russell King - ARM Linux admin
On Sat, Jun 06, 2020 at 08:49:16AM +0100, Jonathan McDowell wrote: > On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > > > mode

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Jonathan McDowell
On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > > mode depending on what it's connected to (e.g. CPU vs external PHY or > > SFP). At

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-05 Thread Andrew Lunn
On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > mode depending on what it's connected to (e.g. CPU vs external PHY or > SFP). At present the driver does no configuration of this port even if > it is

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-05 Thread Marek Behun
On Fri, 5 Jun 2020 19:10:58 +0100 Jonathan McDowell wrote: > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > mode depending on what it's connected to (e.g. CPU vs external PHY or > SFP). At present the driver does no configuration of this port even if > it is selected.

[PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-05 Thread Jonathan McDowell
The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X mode depending on what it's connected to (e.g. CPU vs external PHY or SFP). At present the driver does no configuration of this port even if it is selected. Add support for making sure the SGMII is enabled if it's in use,