Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-02 Thread Jon Mason
On Wed, Feb 1, 2017 at 6:12 PM, Rafał Miłecki wrote: > On 02/01/2017 11:39 PM, Jon Mason wrote: >> >> From: Hari Vyas >> >> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to >> bgmac_set_mac_address() but code assumed u8 *. This caused two

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-02 Thread Jon Mason
On Wed, Feb 1, 2017 at 6:12 PM, Rafał Miłecki wrote: > On 02/01/2017 11:39 PM, Jon Mason wrote: >> >> From: Hari Vyas >> >> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to >> bgmac_set_mac_address() but code assumed u8 *. This caused two bytes >> chopping and the wrong mac

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-02 Thread Sergei Shtylyov
On 2/2/2017 1:39 AM, Jon Mason wrote: From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-02 Thread Sergei Shtylyov
On 2/2/2017 1:39 AM, Jon Mason wrote: From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-01 Thread Rafał Miłecki
On 02/01/2017 11:39 PM, Jon Mason wrote: From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-01 Thread Rafał Miłecki
On 02/01/2017 11:39 PM, Jon Mason wrote: From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon

[PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-01 Thread Jon Mason
From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason

[PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-01 Thread Jon Mason
From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason Fixes: 4e209001b86 ("bgmac: write mac