Re: [PATCH 2/2] nl80211.c: Fixed the wdev_id being used uninitialized.

2014-09-01 Thread Johannes Berg
On Mon, 2014-09-01 at 08:33 -0400, Shakil A Khan wrote: > On Monday 01 September 2014 08:07:38 Johannes Berg wrote: > > > + u64 wdev_id = 0; > > > > it's not used uninitialized, NACK. > > > > johannes > > > > wdev_id can be used uninitialized if have_wdev_id turns to be false, > which may happ

Re: [PATCH 2/2] nl80211.c: Fixed the wdev_id being used uninitialized.

2014-09-01 Thread Shakil A Khan
On Monday 01 September 2014 08:07:38 Johannes Berg wrote: > > + u64 wdev_id = 0; > > it's not used uninitialized, NACK. > > johannes > wdev_id can be used uninitialized if have_wdev_id turns to be false, which may happen if the entry for NL80211_ATTR_WDEV is removed in future. Who knows. --

Re: [PATCH 2/2] nl80211.c: Fixed the wdev_id being used uninitialized.

2014-09-01 Thread Johannes Berg
> + u64 wdev_id = 0; it's not used uninitialized, NACK. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http:/

[PATCH 2/2] nl80211.c: Fixed the wdev_id being used uninitialized.

2014-09-01 Thread Shakil A Khan
Signed-off-by: Shakil A Khan --- net/wireless/nl80211.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index df7b133..6cd7df2 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -76,7 +76,7 @@ __cfg80211_wd