Re: [PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-04-14 Thread Andi Kleen
> fput could go into print_stat_spark I wanted to keep the function generic, so that it can be easily used in other places. Adding the space is somewhat specific to stat. Also the rest of the stat code has the white space printing centralized in the caller too. I suppose makes it easier to

Re: [PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-04-14 Thread Jiri Olsa
On Tue, Mar 25, 2014 at 10:31:39AM -0700, Andi Kleen wrote: > From: Andi Kleen > SNIP > @@ -1176,6 +1176,9 @@ static void print_aggr(char *prefix) > if (run != ena) > fprintf(output, " (%.2f%%)", >

Re: [PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-04-14 Thread Jiri Olsa
On Tue, Mar 25, 2014 at 10:31:39AM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com SNIP @@ -1176,6 +1176,9 @@ static void print_aggr(char *prefix) if (run != ena) fprintf(output, (%.2f%%),

Re: [PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-04-14 Thread Andi Kleen
fput could go into print_stat_spark I wanted to keep the function generic, so that it can be easily used in other places. Adding the space is somewhat specific to stat. Also the rest of the stat code has the white space printing centralized in the caller too. I suppose makes it easier to

Re: [PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-04-13 Thread Jiri Olsa
On Tue, Mar 25, 2014 at 10:31:39AM -0700, Andi Kleen wrote: > From: Andi Kleen > SNIP > index 65a151e..6bf7b6c 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -1176,6 +1176,9 @@ static void print_aggr(char *prefix) > if (run != ena)

Re: [PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-04-13 Thread Jiri Olsa
On Tue, Mar 25, 2014 at 10:31:39AM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com SNIP index 65a151e..6bf7b6c 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -1176,6 +1176,9 @@ static void print_aggr(char *prefix) if

[PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-03-25 Thread Andi Kleen
From: Andi Kleen perf stat -rX prints the stddev for multiple measurements. Just looking at the stddev for judging the quality of the data is a bit dangerous The simplest sanity check is to just look at a simple plot. This patchs add a sparkline to the end of the measurements to make it simple

[PATCH 2/2] perf, tools: Support spark lines in perf stat

2014-03-25 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com perf stat -rX prints the stddev for multiple measurements. Just looking at the stddev for judging the quality of the data is a bit dangerous The simplest sanity check is to just look at a simple plot. This patchs add a sparkline to the end of the measurements