Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-09 Thread Harish Chegondi
On 12/09/2015 03:37 PM, Peter Zijlstra wrote: > On Wed, Dec 09, 2015 at 01:03:43PM -0800, Harish Chegondi wrote: >> >> On 12/08/2015 01:07 AM, Peter Zijlstra wrote: >>> On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: @@ -981,6 +990,8 @@ static int __init

Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-09 Thread Peter Zijlstra
On Wed, Dec 09, 2015 at 01:03:43PM -0800, Harish Chegondi wrote: > > > On 12/08/2015 01:07 AM, Peter Zijlstra wrote: > > On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: > >> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void) > >>break; > >>case 61: /*

Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-09 Thread Harish Chegondi
On 12/08/2015 01:07 AM, Peter Zijlstra wrote: > On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: >> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void) >> break; >> case 61: /* Broadwell */ >> ret = bdw_uncore_pci_init(); >> +case 87: /*

Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-09 Thread Harish Chegondi
On 12/08/2015 01:07 AM, Peter Zijlstra wrote: > On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: >> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void) >> break; >> case 61: /* Broadwell */ >> ret = bdw_uncore_pci_init(); >> +case 87: /*

Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-09 Thread Peter Zijlstra
On Wed, Dec 09, 2015 at 01:03:43PM -0800, Harish Chegondi wrote: > > > On 12/08/2015 01:07 AM, Peter Zijlstra wrote: > > On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: > >> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void) > >>break; > >>case 61: /*

Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-09 Thread Harish Chegondi
On 12/09/2015 03:37 PM, Peter Zijlstra wrote: > On Wed, Dec 09, 2015 at 01:03:43PM -0800, Harish Chegondi wrote: >> >> On 12/08/2015 01:07 AM, Peter Zijlstra wrote: >>> On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: @@ -981,6 +990,8 @@ static int __init

Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-08 Thread Peter Zijlstra
On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: > @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void) > break; > case 61: /* Broadwell */ > ret = bdw_uncore_pci_init(); > + case 87: /* Knights Landing */ > + ret =

Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-08 Thread Peter Zijlstra
On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: > @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void) > break; > case 61: /* Broadwell */ > ret = bdw_uncore_pci_init(); > + case 87: /* Knights Landing */ > + ret =

[PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-07 Thread Harish Chegondi
Knights Landing uncore performance monitoring (perfmon) is derived from Haswell-EP uncore perfmon with several differences. One notable difference is in PCI device IDs. Knights Landing uses common PCI device ID for multiple instances of an uncore PMU device type. In Haswell-EP, each instance of a

[PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

2015-12-07 Thread Harish Chegondi
Knights Landing uncore performance monitoring (perfmon) is derived from Haswell-EP uncore perfmon with several differences. One notable difference is in PCI device IDs. Knights Landing uses common PCI device ID for multiple instances of an uncore PMU device type. In Haswell-EP, each instance of a