Re: [PATCH 2/2] perf script: flush output stream after events in verbose mode

2018-10-22 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 22, 2018 at 03:54:30PM +0200, Jiri Olsa escreveu: > On Mon, Oct 22, 2018 at 12:38:57PM +0200, Milian Wolff wrote: > > SNIP > > > > > > > diff --git a/tools/perf/builtin-script.c > > > > > > b/tools/perf/builtin-script.c > > > > > > index bd468b90801b..ca09b7d2adb7 100644 > > > > > >

Re: [PATCH 2/2] perf script: flush output stream after events in verbose mode

2018-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2018 at 12:38:57PM +0200, Milian Wolff wrote: SNIP > > > > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > > > > > index bd468b90801b..ca09b7d2adb7 100644 > > > > > --- a/tools/perf/builtin-script.c > > > > > +++ b/tools/perf/builtin-script.c > > > > > @

Re: [PATCH 2/2] perf script: flush output stream after events in verbose mode

2018-10-22 Thread Milian Wolff
On Montag, 22. Oktober 2018 12:16:18 CEST Jiri Olsa wrote: > On Mon, Oct 22, 2018 at 12:09:22PM +0200, Milian Wolff wrote: > > On Montag, 22. Oktober 2018 11:43:17 CEST Jiri Olsa wrote: > > > On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote: > > > > When the perf script output is writte

Re: [PATCH 2/2] perf script: flush output stream after events in verbose mode

2018-10-22 Thread Jiri Olsa
On Mon, Oct 22, 2018 at 12:09:22PM +0200, Milian Wolff wrote: > On Montag, 22. Oktober 2018 11:43:17 CEST Jiri Olsa wrote: > > On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote: > > > When the perf script output is written to a terminal stream, > > > the normal output of `perf script` wo

Re: [PATCH 2/2] perf script: flush output stream after events in verbose mode

2018-10-22 Thread Milian Wolff
On Montag, 22. Oktober 2018 11:43:17 CEST Jiri Olsa wrote: > On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote: > > When the perf script output is written to a terminal stream, > > the normal output of `perf script` would get buffered, but its > > debug output would be written directly.

Re: [PATCH 2/2] perf script: flush output stream after events in verbose mode

2018-10-22 Thread Jiri Olsa
On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote: > When the perf script output is written to a terminal stream, > the normal output of `perf script` would get buffered, but its > debug output would be written directly. This made it quite hard > to figure out where a given debug output

[PATCH 2/2] perf script: flush output stream after events in verbose mode

2018-10-21 Thread Milian Wolff
When the perf script output is written to a terminal stream, the normal output of `perf script` would get buffered, but its debug output would be written directly. This made it quite hard to figure out where a given debug output is coming from. We can improve on this by flushing the output buffer a