On 1/21/15 6:32 PM, Victor Kamensky wrote:
May I use 'Acked-by' (maybe 'Tested-by' as well) with
your name for the shorter (no filename_copy) as above
version of the patch for .gnu_debuglink issue fix.
You can add both to your second patch -- the short version.
Acked-and-Tested-by: David
On 21 January 2015 at 16:53, David Ahern wrote:
> On 1/21/15 5:34 PM, Victor Kamensky wrote:
>>
>> diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
>> index 45be944..ca8d8d5 100644
>> --- a/tools/perf/util/dso.c
>> +++ b/tools/perf/util/dso.c
>> @@ -45,13 +45,13 @@ int
On 1/21/15 5:34 PM, Victor Kamensky wrote:
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 45be944..ca8d8d5 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -45,13 +45,13 @@ int dso__read_binary_type_filename(const struct dso *dso,
case
entation because
open happens first but update happens after that. But that
is specific dependency on current implementation of
filename__read_debuglink function. It did not feel quite
right to me, but practically it could be OK.
Here is the first version of the without filename_copy.
Practically I am O
On 1/19/15 10:50 AM, Victor Kamensky wrote:
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 45be944..6a2f663 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -42,19 +42,30 @@ int dso__read_binary_type_filename(const struct dso *dso,
size_t len;
On 1/19/15 10:50 AM, Victor Kamensky wrote:
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 45be944..6a2f663 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -42,19 +42,30 @@ int dso__read_binary_type_filename(const struct dso *dso,
size_t len;
this version:
From cafc06d95886f1d82f7b127af58a51384c0fe931 Mon Sep 17 00:00:00 2001
From: Victor Kamensky victor.kamen...@linaro.org
Date: Mon, 12 Jan 2015 17:33:06 -0800
Subject: [PATCH 2/2] perf symbols: debuglink should take symfs option into
account
Currently code that tries to read
On 1/21/15 5:34 PM, Victor Kamensky wrote:
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 45be944..ca8d8d5 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -45,13 +45,13 @@ int dso__read_binary_type_filename(const struct dso *dso,
case
On 21 January 2015 at 16:53, David Ahern dsah...@gmail.com wrote:
On 1/21/15 5:34 PM, Victor Kamensky wrote:
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 45be944..ca8d8d5 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -45,13 +45,13 @@ int
On 1/21/15 6:32 PM, Victor Kamensky wrote:
May I use 'Acked-by' (maybe 'Tested-by' as well) with
your name for the shorter (no filename_copy) as above
version of the patch for .gnu_debuglink issue fix.
You can add both to your second patch -- the short version.
Acked-and-Tested-by: David
Hi Guys,
If it helps to look at below patch, here is a test case
for failure that below patch addresses.
Run on target with root NFS mounted in this case. Current
target is ARM TC2 board.
But I am pretty sure the same sequence will fail on any other
device that is built in cross compiled way,
Hi Guys,
If it helps to look at below patch, here is a test case
for failure that below patch addresses.
Run on target with root NFS mounted in this case. Current
target is ARM TC2 board.
But I am pretty sure the same sequence will fail on any other
device that is built in cross compiled way,
Currently code that tries to read corresponding debug symbol
file from .gnu_debuglink section (DSO_BINARY_TYPE__DEBUGLINK)
does not take in account symfs option, so filename__read_debuglink
function cannot open ELF file, if symfs option is used.
Fix is to add proper handling of symfs as it is
Currently code that tries to read corresponding debug symbol
file from .gnu_debuglink section (DSO_BINARY_TYPE__DEBUGLINK)
does not take in account symfs option, so filename__read_debuglink
function cannot open ELF file, if symfs option is used.
Fix is to add proper handling of symfs as it is
14 matches
Mail list logo
