Re: [PATCH 2/2] perf tools: Fix term parsing for raw syntax

2020-07-26 Thread Jiri Olsa
On Sat, Jul 25, 2020 at 09:58:13AM -0700, Ian Rogers wrote: SNIP > > ret = parse_events_terms(, t->str); > > if (ret) { > > pr_debug("failed to parse terms '%s', err %d\n", > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > > index

Re: [PATCH 2/2] perf tools: Fix term parsing for raw syntax

2020-07-25 Thread Ian Rogers
On Sat, Jul 25, 2020 at 5:20 AM Jiri Olsa wrote: > > Jin Yao reported issue with possible conflict between raw > events and term values in pmu event syntax. > > Currently following syntax is resolved as raw event with > 0xead value: > uncore_imc_free_running/read/ > > instead of using 'read'

[PATCH 2/2] perf tools: Fix term parsing for raw syntax

2020-07-25 Thread Jiri Olsa
Jin Yao reported issue with possible conflict between raw events and term values in pmu event syntax. Currently following syntax is resolved as raw event with 0xead value: uncore_imc_free_running/read/ instead of using 'read' term from uncore_imc_free_running pmu, because 'read' is correct raw