Re: [PATCH 2/2] pinctrl: core: Add proper mutex lock in pinctrl_request_gpio

2013-08-28 Thread Linus Walleij
On Thu, Aug 22, 2013 at 5:41 AM, Axel Lin wrote: > 2013/8/22 Linus Walleij : >>> + mutex_lock(&pctldev->mutex); >>> + >>> /* Convert to the pin controllers number space */ >>> pin = gpio_to_pin(range, gpio); >>> >>> ret = pinmux_request_gpio(pctldev, range, pin, gpio

Re: [PATCH 2/2] pinctrl: core: Add proper mutex lock in pinctrl_request_gpio

2013-08-21 Thread Axel Lin
2013/8/22 Linus Walleij : > On Mon, Aug 19, 2013 at 4:07 AM, Axel Lin wrote: > >> This one is missed in commit 42fed7ba "pinctrl: move subsystem mutex to >> pinctrl_dev struct". > > I think this was never there. I think it was protected by the global pinctrl_mutex in v3.9, you can check the sourc

Re: [PATCH 2/2] pinctrl: core: Add proper mutex lock in pinctrl_request_gpio

2013-08-21 Thread Linus Walleij
On Mon, Aug 19, 2013 at 4:07 AM, Axel Lin wrote: > This one is missed in commit 42fed7ba "pinctrl: move subsystem mutex to > pinctrl_dev struct". I think this was never there. > Signed-off-by: Axel Lin > --- > drivers/pinctrl/core.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a

[PATCH 2/2] pinctrl: core: Add proper mutex lock in pinctrl_request_gpio

2013-08-18 Thread Axel Lin
This one is missed in commit 42fed7ba "pinctrl: move subsystem mutex to pinctrl_dev struct". Signed-off-by: Axel Lin --- drivers/pinctrl/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 53c40d9..92f86ab 100644 --- a/drivers/pinc