Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-06-25 Thread Linus Walleij
On Fri, Jun 21, 2019 at 6:20 AM Sean Wang wrote: > The change is worth rewording the commit message you added above as an > instance > and adding Fixes tag as a fixup to mean you're fixing the existing > problem in the driver. > > And then Acked-by: Sean Wang I'm waiting for an updated version

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-06-20 Thread Sean Wang
Hi, Nicolas On Sun, Apr 28, 2019 at 8:55 PM Nicolas Boichat wrote: > > During suspend/resume, mtk_eint_mask may be called while > wake_mask is active. For example, this happens if a wake-source > with an active interrupt handler wakes the system: > irq/pm.c:irq_pm_check_wakeup would disable the i

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-06-10 Thread Stephen Boyd
Quoting Evan Green (2019-05-30 10:12:03) > On Wed, May 15, 2019 at 1:05 AM Nicolas Boichat wrote: > > > > On Wed, May 15, 2019 at 4:14 AM Stephen Boyd wrote: > > > > > We could immediately unmask those lines in the hardware when the > > > set_wake() callback is called. That way the genirq layer c

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-06-05 Thread Chuanjia Liu
On Tue, 2019-06-04 at 08:57 +0800, Nicolas Boichat wrote: > On Mon, Jun 3, 2019 at 4:01 PM Chuanjia Liu wrote: > > > > On Fri, 2019-05-31 at 10:17 -0700, Evan Green wrote: > > > On Fri, May 31, 2019 at 1:06 AM Chuanjia Liu > > > wrote: > > > > > > > > On Thu, 2019-05-30 at 10:12 -0700, Evan Gree

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-06-03 Thread Nicolas Boichat
On Mon, Jun 3, 2019 at 4:01 PM Chuanjia Liu wrote: > > On Fri, 2019-05-31 at 10:17 -0700, Evan Green wrote: > > On Fri, May 31, 2019 at 1:06 AM Chuanjia Liu > > wrote: > > > > > > On Thu, 2019-05-30 at 10:12 -0700, Evan Green wrote: > > > > On Wed, May 15, 2019 at 1:05 AM Nicolas Boichat > > >

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-06-03 Thread Chuanjia Liu
On Fri, 2019-05-31 at 10:17 -0700, Evan Green wrote: > On Fri, May 31, 2019 at 1:06 AM Chuanjia Liu > wrote: > > > > On Thu, 2019-05-30 at 10:12 -0700, Evan Green wrote: > > > On Wed, May 15, 2019 at 1:05 AM Nicolas Boichat > > > wrote: > > > > > > > > On Wed, May 15, 2019 at 4:14 AM Stephen Bo

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-05-31 Thread Evan Green
On Fri, May 31, 2019 at 1:06 AM Chuanjia Liu wrote: > > On Thu, 2019-05-30 at 10:12 -0700, Evan Green wrote: > > On Wed, May 15, 2019 at 1:05 AM Nicolas Boichat > > wrote: > > > > > > On Wed, May 15, 2019 at 4:14 AM Stephen Boyd wrote: > > > > > > > > Quoting Nicolas Boichat (2019-05-13 18:37:5

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-05-31 Thread Chuanjia Liu
On Thu, 2019-05-30 at 10:12 -0700, Evan Green wrote: > On Wed, May 15, 2019 at 1:05 AM Nicolas Boichat wrote: > > > > On Wed, May 15, 2019 at 4:14 AM Stephen Boyd wrote: > > > > > > Quoting Nicolas Boichat (2019-05-13 18:37:58) > > > > On Tue, May 14, 2019 at 6:29 AM Stephen Boyd > > > > wrote:

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-05-30 Thread Evan Green
On Wed, May 15, 2019 at 1:05 AM Nicolas Boichat wrote: > > On Wed, May 15, 2019 at 4:14 AM Stephen Boyd wrote: > > > > Quoting Nicolas Boichat (2019-05-13 18:37:58) > > > On Tue, May 14, 2019 at 6:29 AM Stephen Boyd wrote: > > > > > > > > Quoting Nicolas Boichat (2019-04-28 20:55:15) > > > > > D

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-05-15 Thread Nicolas Boichat
On Wed, May 15, 2019 at 4:14 AM Stephen Boyd wrote: > > Quoting Nicolas Boichat (2019-05-13 18:37:58) > > On Tue, May 14, 2019 at 6:29 AM Stephen Boyd wrote: > > > > > > Quoting Nicolas Boichat (2019-04-28 20:55:15) > > > > During suspend/resume, mtk_eint_mask may be called while > > > > wake_mas

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-05-14 Thread Stephen Boyd
Quoting Nicolas Boichat (2019-05-13 18:37:58) > On Tue, May 14, 2019 at 6:29 AM Stephen Boyd wrote: > > > > Quoting Nicolas Boichat (2019-04-28 20:55:15) > > > During suspend/resume, mtk_eint_mask may be called while > > > wake_mask is active. For example, this happens if a wake-source > > > with

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-05-13 Thread Nicolas Boichat
On Tue, May 14, 2019 at 6:29 AM Stephen Boyd wrote: > > Quoting Nicolas Boichat (2019-04-28 20:55:15) > > During suspend/resume, mtk_eint_mask may be called while > > wake_mask is active. For example, this happens if a wake-source > > with an active interrupt handler wakes the system: > > irq/pm.c

Re: [PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-05-13 Thread Stephen Boyd
Quoting Nicolas Boichat (2019-04-28 20:55:15) > During suspend/resume, mtk_eint_mask may be called while > wake_mask is active. For example, this happens if a wake-source > with an active interrupt handler wakes the system: > irq/pm.c:irq_pm_check_wakeup would disable the interrupt, so > that it ca

[PATCH 2/2] pinctrl: mediatek: Update cur_mask in mask/mask ops

2019-04-28 Thread Nicolas Boichat
During suspend/resume, mtk_eint_mask may be called while wake_mask is active. For example, this happens if a wake-source with an active interrupt handler wakes the system: irq/pm.c:irq_pm_check_wakeup would disable the interrupt, so that it can be handled later on in the resume flow. However, this