Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-29 Thread Stephen Warren
On 07/27/2013 06:11 AM, Laxman Dewangan wrote: > Hi Stephen, > Thanks for detail review. > Agree on most of review. Some info/answer on some of query. > > On Saturday 27 July 2013 12:39 AM, Stephen Warren wrote: >> (Also CC'ing in the DT bindings maintainers, hence quoting all of the >> binding.)

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-29 Thread Stephen Warren
On 07/27/2013 06:11 AM, Laxman Dewangan wrote: Hi Stephen, Thanks for detail review. Agree on most of review. Some info/answer on some of query. On Saturday 27 July 2013 12:39 AM, Stephen Warren wrote: (Also CC'ing in the DT bindings maintainers, hence quoting all of the binding.) On

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-28 Thread Mark Brown
On Sat, Jul 27, 2013 at 03:53:27PM +0530, Laxman Dewangan wrote: > On Friday 26 July 2013 10:11 PM, Mark Brown wrote: > >>+ gpio4_sysen1, gpio5_clk32kgaudio_usb_psel, gpio6_sysen2, > >Would it not be easier to just name the GPIOs gpioN rather than using > >the full names with the possible

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-28 Thread Mark Brown
On Sat, Jul 27, 2013 at 03:53:27PM +0530, Laxman Dewangan wrote: On Friday 26 July 2013 10:11 PM, Mark Brown wrote: + gpio4_sysen1, gpio5_clk32kgaudio_usb_psel, gpio6_sysen2, Would it not be easier to just name the GPIOs gpioN rather than using the full names with the possible functions?

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-27 Thread Laxman Dewangan
Hi Stephen, Thanks for detail review. Agree on most of review. Some info/answer on some of query. On Saturday 27 July 2013 12:39 AM, Stephen Warren wrote: (Also CC'ing in the DT bindings maintainers, hence quoting all of the binding.) On 07/26/2013 04:15 AM, Laxman Dewangan wrote: That field

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-27 Thread Laxman Dewangan
On Friday 26 July 2013 10:11 PM, Mark Brown wrote: * PGP Signed by an unknown key On Fri, Jul 26, 2013 at 03:45:54PM +0530, Laxman Dewangan wrote: +pins: gpio0_id, gpio1_vbus_det_led1_pwm1, gpio2_regen_led2_pwm2, gpio3_chrg_det, + gpio4_sysen1, gpio5_clk32kgaudio_usb_psel,

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-27 Thread Laxman Dewangan
On Friday 26 July 2013 10:11 PM, Mark Brown wrote: * PGP Signed by an unknown key On Fri, Jul 26, 2013 at 03:45:54PM +0530, Laxman Dewangan wrote: +pins: gpio0_id, gpio1_vbus_det_led1_pwm1, gpio2_regen_led2_pwm2, gpio3_chrg_det, + gpio4_sysen1, gpio5_clk32kgaudio_usb_psel,

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-27 Thread Laxman Dewangan
Hi Stephen, Thanks for detail review. Agree on most of review. Some info/answer on some of query. On Saturday 27 July 2013 12:39 AM, Stephen Warren wrote: (Also CC'ing in the DT bindings maintainers, hence quoting all of the binding.) On 07/26/2013 04:15 AM, Laxman Dewangan wrote: That field

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-26 Thread Stephen Warren
(Also CC'ing in the DT bindings maintainers, hence quoting all of the binding.) On 07/26/2013 04:15 AM, Laxman Dewangan wrote: > TI Palam series Power Management IC have multiple pins which can be S/Palam/Palmas/ right? This name seems to get typo'd an awful lot, both in this patch and others...

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-26 Thread Mark Brown
On Fri, Jul 26, 2013 at 03:45:54PM +0530, Laxman Dewangan wrote: > +pins: gpio0_id, gpio1_vbus_det_led1_pwm1, gpio2_regen_led2_pwm2, > gpio3_chrg_det, > + gpio4_sysen1, gpio5_clk32kgaudio_usb_psel, gpio6_sysen2, > + gpio7_msecure_pwrhold, gpio8_sim1rsti, gpio9_low_vbat, > +

[PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-26 Thread Laxman Dewangan
TI Palam series Power Management IC have multiple pins which can be configured for different functionality. This pins can be configured for different function. Also their properties like pull up/down, open drain enable/disable are configurable. Add support for pincontrol driver Palmas series

[PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-26 Thread Laxman Dewangan
TI Palam series Power Management IC have multiple pins which can be configured for different functionality. This pins can be configured for different function. Also their properties like pull up/down, open drain enable/disable are configurable. Add support for pincontrol driver Palmas series

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-26 Thread Mark Brown
On Fri, Jul 26, 2013 at 03:45:54PM +0530, Laxman Dewangan wrote: +pins: gpio0_id, gpio1_vbus_det_led1_pwm1, gpio2_regen_led2_pwm2, gpio3_chrg_det, + gpio4_sysen1, gpio5_clk32kgaudio_usb_psel, gpio6_sysen2, + gpio7_msecure_pwrhold, gpio8_sim1rsti, gpio9_low_vbat, +

Re: [PATCH 2/2] pinctrl: palmas: add pincontrol driver

2013-07-26 Thread Stephen Warren
(Also CC'ing in the DT bindings maintainers, hence quoting all of the binding.) On 07/26/2013 04:15 AM, Laxman Dewangan wrote: TI Palam series Power Management IC have multiple pins which can be S/Palam/Palmas/ right? This name seems to get typo'd an awful lot, both in this patch and others...